Upgrade changed external_url

Summary

We have the gitlab-ce added to unattended upgrade whitelist. Tonight it auto-updated and didn't start. We also have Gitlab running on EC2 in AWS.

Gitlab changed the external_url in /etc/gitlab/gitlab.rb to the public URL of our EC2 instance - http://ec2-<ip>.<region>.compute.amazonaws.com/.

After the upgrade finished, Nginx failed to start on this error

nginx: [emerg] could not build server_names_hash, you should increase server_names_hash_bucket_size: 64

Because the ec2 url is too long.

I've panicked for a bit, fixed the url, restarted Gitlab and it came right back up.

Steps to reproduce

No idea, probably a problem in upgrade scripts?

Details of package version

Provide the package version installation details

Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                       Version                    Architecture               Description
+++-==========================================-==========================-==========================-=========================================================================================
ii  gitlab-ce                                  12.7.0-ce.0                amd64                      GitLab Community Edition (including NGINX, Postgres, Redis)
un  gitlab-ee                                                                            (no description available)

Environment details

• Operating System: Ubuntu 16.04.6 LTS
• Installation Target, remove incorrect values:
  • VM: AWS
• Installation Type, remove incorrect values:
  • Upgrade from version 12.6.4-ce.0
• Is this a single node installation
• Resources
  • CPU: Intel(R) Xeon(R) CPU E5-2676 v3 @ 2.40GHz
  • Memory total: 4GB