On pg-upgrade timeouts `die` method is reported undefined
Noticed in https://gitlab.zendesk.com/agent/tickets/128330
Stopping the databaseok down: postgresql: 0s, normally up
Stopping the database: OK
Symlink correct version of binaries: OK
Creating temporary data directory: OK
Initializing the new database: OK
Upgrading the data:Error upgrading the data to version 10.7
STDOUT:
STDERR: timed out
Upgrading the data: NOT OK
Traceback (most recent call last):
7: from /opt/gitlab/embedded/bin/omnibus-ctl:23:in `<main>'
6: from /opt/gitlab/embedded/bin/omnibus-ctl:23:in `load'
5: from /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/omnibus-ctl-0.6.0/bin/omnibus-ctl:31:in `<top (required)>'
4: from /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/omnibus-ctl-0.6.0/lib/omnibus-ctl.rb:746:in `run'
3: from /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/omnibus-ctl-0.6.0/lib/omnibus-ctl.rb:204:in `block in add_command_under_category'
2: from /opt/gitlab/embedded/service/omnibus-ctl/pg-upgrade.rb:166:in `block in load_file'
1: from /opt/gitlab/embedded/service/omnibus-ctl/pg-upgrade.rb:220:in `general_upgrade'
/opt/gitlab/embedded/service/omnibus-ctl/lib/gitlab_ctl/pg_upgrade.rb:111:in `run_pg_upgrade': undefined method `die' for #<GitlabCtl::PgUpgrade:0x0000000002e20868> (NoMethodError)
Ensuring PostgreSQL is updated: NOT OK
Error ensuring PostgreSQL is updated. Please check the logs
dpkg: error processing package gitlab-ee (--configure)
gitlab-ctl pg-update passes ok afterwards, gitlab-ctl start starts the deploy page.
undefined method 'die' for #<GitlabCtl::PgUpgrade:0x0000000002e20868>
seems to point a regression from recent refactor in !3316 (merged).
/cc @ibaum
Edited by Balasankar 'Balu' C