Postgresql user password does not revert to NULL on reconfigure if previous setting of password removed from gitlab.rb
Found out during review of !3058 (comment 143496084)
Consider the scenario:
- I set
postgresql['sql_user_password']
setting in gitlab.rb - Ran reconfigure - user got created/updated with the password.
- I realized that was a mistake, and want to go back to default password (which is `NULL)
- I removed the setting from gitlab.rb, and ran reconfigure again.
- Nothing happened.
If we are not explicitly setting a password, property_is_set
check fails, and we don't enter the password altering block. So, this breaks "go back to a nil password" workflow. We should modify the resource definition to accept nil
as a value for password, and either set it as a default value there, or do it in the recipe.
@ibaum I assume the current flow was not intentional - could you confirm?