HTTP2 is not enabled for registry service
Summary
I noticed that the default value of nginx['http2_enabled']
is true
, which can be seen doing:
~|⇒ cat /var/opt/gitlab/nginx/conf/gitlab-http.conf | grep listen
listen *:3503 ssl http2;
But if I try to grep the registry config file of nginx, I get:
~|⇒ cat /var/opt/gitlab/nginx/conf/gitlab-registry.conf | grep listen
listen *:3504 ssl;
which means that registry_nginx['http2_enabled']
isn't true
as stated in docs.
Steps to reproduce
- Enable registry
- Cat registry nginx config file
Example Project
N/A
What is the current bug behavior?
HTTP2 is not enabled by default.
What is the expected correct behavior?
HTTP2 should be enabled by default.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 9.5 Proxy: no Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.18.0 Sidekiq Version:5.1.3 Go Version: unknown
GitLab information Version: 11.3.0-ce Revision: 17bd59ad Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.8 URL: https://gitlab.********** HTTP Clone URL: https://gitlab.*/some-group/some-project.git SSH Clone URL: git@:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: no
GitLab Shell Version: 8.3.3 Repository storage paths: default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...
GitLab Shell version >= 8.3.3 ? ... OK (8.3.3) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 2/4 ... ok 2/5 ... ok 2/6 ... ok 5/8 ... ok 2/9 ... ok 2/10 ... ok 2/11 ... ok 2/14 ... ok 5/15 ... ok 12/18 ... ok 12/19 ... ok 14/20 ... ok 15/21 ... ok 16/22 ... ok 15/23 ... ok 15/24 ... ok 17/25 ... repository is empty 15/26 ... ok 18/27 ... ok 19/29 ... ok 20/30 ... ok 20/31 ... ok 20/32 ... ok 21/33 ... ok 22/34 ... ok 15/35 ... ok 16/36 ... ok 15/37 ... ok 23/38 ... ok 15/39 ... ok 25/40 ... ok 15/41 ... ok 15/42 ... ok 15/43 ... ok 15/44 ... ok 12/45 ... ok 15/47 ... ok 17/49 ... ok 15/50 ... repository is empty 12/51 ... ok 15/52 ... ok 15/53 ... ok 23/55 ... ok 15/56 ... ok 15/57 ... ok 15/58 ... ok 17/59 ... ok 12/60 ... ok 12/61 ... ok 12/62 ... ok 15/63 ... repository is empty 16/64 ... ok 17/65 ... ok 15/67 ... ok 6/69 ... ok 15/71 ... ok 17/72 ... repository is empty 36/75 ... repository is empty 16/76 ... repository is empty 15/77 ... ok 6/79 ... ok 16/80 ... ok 37/81 ... ok 16/82 ... repository is empty 15/83 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/4 ... yes 2/5 ... yes 2/6 ... yes 5/8 ... yes 2/9 ... yes 2/10 ... yes 2/11 ... yes 2/14 ... yes 5/15 ... yes 12/18 ... yes 12/19 ... yes 14/20 ... yes 15/21 ... yes 16/22 ... yes 15/23 ... yes 15/24 ... yes 17/25 ... yes 15/26 ... yes 18/27 ... yes 19/29 ... yes 20/30 ... yes 20/31 ... yes 20/32 ... yes 21/33 ... yes 22/34 ... yes 15/35 ... yes 16/36 ... yes 15/37 ... yes 23/38 ... yes 15/39 ... yes 25/40 ... yes 15/41 ... yes 15/42 ... yes 15/43 ... yes 15/44 ... yes 12/45 ... yes 15/47 ... yes 17/49 ... yes 15/50 ... yes 12/51 ... yes 15/52 ... yes 15/53 ... yes 23/55 ... yes 15/56 ... yes 15/57 ... yes 15/58 ... yes 17/59 ... yes 12/60 ... yes 12/61 ... yes 12/62 ... yes 15/63 ... yes 16/64 ... yes 17/65 ... yes 15/67 ... yes 6/69 ... yes 15/71 ... yes 17/72 ... yes 36/75 ... yes 16/76 ... yes 15/77 ... yes 6/79 ... yes 16/80 ... yes 37/81 ... yes 16/82 ... yes 15/83 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.18.0) Git user has default SSH configuration? ... yes Active users: ... 10 Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)
Checking GitLab ... Finished