Upgrading from GitLab 10.6 -> 10.8+ does not regenerate pgbouncer databases.ini
On GPRD and GSTG, I noticed databases.ini
was using the wrong user, gitlab-psql
, whereas databases.json
was using user pgbouncer
.
!2482 (diffs) was shipped in GitLab 10.8. However, databases.ini
is generated only if databases.json
changed. Since it didn't change when we upgraded to 11.0.2, databases.ini
stayed the same.
To work around the problem, you can remove databases.json
or edit the file so that the gitlab-ctl reconfigure
will do the right thing.
A couple of ways we can solve this:
- Add some sort of version number to the
databases.json
so that any changes there will regeneratedatabases.ini
. - Change the script to read in the
databases.ini
and check that it is consistent withdatabases.json
. - Always regenerate
databases.ini
and only reloadpgbouncer
if something changed
/cc: @ibaum
Edited by Stan Hu