AWS configuration section obsolete?

I noticed there are a bunch of configuration options to support CarrierWave and AWS:

default['gitlab']['gitlab-rails']['aws_enable'] = false
default['gitlab']['gitlab-rails']['aws_access_key_id'] = nil
default['gitlab']['gitlab-rails']['aws_secret_access_key'] = nil
default['gitlab']['gitlab-rails']['aws_bucket'] = nil
default['gitlab']['gitlab-rails']['aws_region'] = nil

These are used to generate aws.yml, which is loaded by config/initializers/carrierwave.rb in GitLab.

We don't seem to be using it for GitLab.com, and all object storage configuration appears to be handled within their own section (e.g. uploads, lfs, etc.).

Can we remove this? This confused me because I wasn't sure if we needed to be making changes both in aws.yml and in gitlab.yml.

/cc: @jacobvosmaer-gitlab, @mbergeron, @dosuken123

Edited by Stan Hu