Gitaly should be running when applying migrations during upgrade
During an upgrade from 10.6 to 10.7 (RC) I saw this:
Shutting down all GitLab services except those needed for migrations
ok: down: gitaly: 1s, normally up
ok: down: gitlab-monitor: 0s, normally up
ok: down: gitlab-workhorse: 0s, normally up
ok: down: logrotate: 1s, normally up
ok: down: nginx: 0s, normally up
ok: down: node-exporter: 1s, normally up
ok: down: postgres-exporter: 0s, normally up
ok: down: postgresql: 0s, normally up
ok: down: prometheus: 0s, normally up
ok: down: redis: 0s, normally up
ok: down: redis-exporter: 1s, normally up
ok: down: sidekiq: 0s, normally up
ok: down: unicorn: 0s, normally up
ok: run: postgresql: (pid 23467) 1s
ok: run: redis: (pid 23475) 0s
run: postgresql: (pid 23467) 1s; run: log: (pid 1089) 4869s
run: redis: (pid 23475) 0s; run: log: (pid 1069) 4869s
Reconfiguring GitLab to apply migrations
That looks like we run gitlab-ctl reconfigure
with only Postgres and Redis up. We should add Gitaly to that list. Some migrations touch Git repositories, and (soon) that can't happen without Gitaly.