no implicit conversion of nil into String

Summary

After upgrade, access to project pages leads to 500 errors.

Steps to reproduce

Upgrade from 10.4 to 10.5 Go a to a project page See error 500 So I re-run gitlab-ctl reconfigure and have the output below.

What is the current bug behavior?

Go a to a project page See error 500

What is the expected correct behavior?

Go a to a project page See project page

Relevant logs

(Paste any relevant logs.)
(Live log output can be found with `sudo gitlab-ctl tail`.)
(Log files live in `/var/log/gitlab` by default.)

Details of package version

root@crnt-gitlab:~# dpkg-query -l gitlab-*

Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                          Version                     Architecture                Description
+++-=============================================-===========================-===========================-===============================================================================================
ii  gitlab-ce                                     10.5.0-ce.0                 amd64                       GitLab Community Edition (including NGINX, Postgres, Redis)
un  gitlab-ci-multi-runner                        <none>                      <none>                      (no description available)
un  gitlab-ci-multi-runner-beta                   <none>                      <none>                      (no description available)
un  gitlab-ee                                     <none>                      <none>                      (no description available)
ii  gitlab-runner                                 10.5.0                      amd64                       GitLab Runner
un  gitlab-runner-beta                            <none>                      <none>                      (no description available)

Environment details

Operating System: Debian 9.x
Installation Target, remove incorrect values:
- VM: Scaleway
Installation Type, remove incorrect values:
- Upgrade from version 10.4
Is this a single or multiple node installation? SINGLE
Resources
- CPU: 4 vCPU 64 bits
- Memory total: 4 Gb RAM

Configuration details

Starting Chef Client, version 12.21.31
resolving cookbooks for run list: ["gitlab"]
Synchronizing Cookbooks:
  - gitlab (0.0.1)
  - package (0.1.0)
  - postgresql (0.1.0)
  - registry (0.1.0)
  - mattermost (0.1.0)
  - nginx (0.1.0)
  - letsencrypt (0.1.0)
  - runit (0.14.2)
  - consul (0.0.0)
  - gitaly (0.1.0)
  - acme (3.1.0)
  - compat_resource (12.19.0)
Installing Cookbook Gems:
Compiling Cookbooks...

================================================================================
Recipe Compile Error in /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/default.rb
================================================================================

TypeError
---------
no implicit conversion of nil into String

Cookbook Trace:
---------------
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:92:in `join'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:92:in `block in parse_git_data_dirs'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:89:in `each'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:89:in `map'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:89:in `parse_git_data_dirs'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:21:in `parse_variables'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:174:in `block in generate_config'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:172:in `each'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:172:in `generate_config'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/config.rb:26:in `from_file'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/default.rb:26:in `from_file'

Relevant File Content:
----------------------
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:

 85:      end
 86:
 87:      def parse_git_data_dirs
 88:        Gitlab['gitlab_rails']['repositories_storages'] =
 89:          Hash[converted_git_data_dirs.map do |name, data_directory|
 90:            shard_gitaly_address = data_directory['gitaly_address'] || gitaly_address
 91:
 92>>           defaults = { 'path' => File.join(data_directory['path'], 'repositories'), 'gitaly_address' => shard_gitaly_address }
 93:            params = data_directory.merge(defaults)
 94:
 95:            [name, params]
 96:          end]
 97:      end
 98:
 99:      def parse_gitaly_storages
100:        return unless Gitlab['gitaly']['storage'].nil?
101:

System Info:
------------
chef_version=12.21.31
platform=debian
platform_version=9.3
ruby=ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-linux]
program_name=chef-client worker: ppid=8210;start=16:11:40;
executable=/opt/gitlab/embedded/bin/chef-client


Running handlers:
There was an error running gitlab-ctl reconfigure:

no implicit conversion of nil into String

Running handlers complete
Chef Client failed. 0 resources updated in 17 seconds