Skip to content

Setting replicator password is too quiet

In https://docs.gitlab.com/ee/gitlab-geo/database.html#step-1-configure-the-primary-server

Setting a password for gitlab_replicator in step 1.4 is a "silent" experience. There is no prompt or feedback from the system to indicate that I am entering a password, nor that a password has been entered. Also tbh not clear to me what the replication user is / does and how critical access to the password from a security perspective.

Is there a way to make the prompt noisier and the docs clearer on the importance?

Proposal

Since we're setting a password, ask for password confirmation. This can be done my modifying Geo::Replication#ask_pass to use GitlabCtl::Util.get_password, this is already used to set up pgbouncer.

Edited by Toon Claes