Investigate consolidating attributes postgresql['dir'] and postgresql['data_dir']
pg-upgrade has run into some issues when one or both are set. See #2213 (closed) and #1930 (closed)
It isn't 100% clear to me that we need two separate attributes. If we can use only one, then that would be great. Otherwise, we should document when to set one or both.