OmnibusHelper needs to be more precise
For OmnibusHelper class:
- needs to be split from the
libraries/helper.rb
into a separate file - Fully covered in specs
- Fix the edge case where
should_notify?
returns true when the service is not enabled.
The edge case can be found by:
- Enable a service, run reconfigure, eg.
external_url 'http://example.com
- Disable a service, eg.
unicorn['enable'] = false
and run reconfigure - Observe the reconfigure fail.
The reason is that the should_notify?
check for existence of service file and because reconfigure didn't manage to remove the file it returns true.
We need to check if a service is enabled. The challenge is that we need to pass the node
object which we currently don't do so specs are a must.