doc/settings/database.md

@@ -898,7 +898,7 @@ correct executables by running both the [backup](https://docs.gitlab.com/ee/rake
 
 ### Upgrade a non-packaged PostgreSQL database
 
-You can upgrade the external database as suggested by the provider after stopping all the processes that are connected to the database (Puma, Sidekiq):
+You can upgrade the external database after stopping all the processes that are connected to the database (Puma, Sidekiq):
 
 ```shell
 sudo gitlab-ctl stop puma
@@ -907,20 +907,20 @@ sudo gitlab-ctl stop sidekiq
 
 Before proceeding with the upgrade, note the following:
 
-- Before upgrading, review the [GitLab and PostgreSQL version compatibility table](https://docs.gitlab.com/ee/administration/package_information/postgresql_versions.html)
-  to determine your upgrade path. When using GitLab backup or restore, you
-  _must_ keep the same version of GitLab; first, upgrade PostgreSQL, and then GitLab.
+- Check compatibility between GitLab releases and PostgreSQL versions:
+  - Read about which GitLab versions introduced a requirement for a
+    [minimum PostgreSQL version](https://docs.gitlab.com/ee/install/requirements.html#postgresql-requirements).
+  - Read about significant changes to the PostgreSQL versions which
+    [shipped with Omnibus](https://docs.gitlab.com/ee/administration/package_information/postgresql_versions.html):
+    Omnibus GitLab is tested for compatibility with the major releases of PostgreSQL that it ships with.
+- When using GitLab backup or restore, you _must_ keep the same version of GitLab.
+  If you plan to upgrade to a later GitLab version as well, upgrade PostgreSQL first.
 - The [backup and restore Rake task](https://docs.gitlab.com/ee/raketasks/backup_restore.html#create-a-backup-of-the-gitlab-system)
   can be used to back up and restore the database to a later version of PostgreSQL.
-- If configuring a version number whose binaries are unavailable on the file
-  system, GitLab/Rails uses the default database's version binaries (default as
-  per [GitLab and PostgreSQL version compatibility table](https://docs.gitlab.com/ee/administration/package_information/postgresql_versions.html)).
-- If you're using Amazon RDS and are seeing extremely high (near 100%) CPU
-  utilization following a major version upgrade (for example, from `10.x` to
-  `11.x`), running an `ANALYZE VERBOSE;` query may be necessary to recreate query
-  plans and reduce CPU utilization on the database server(s).
-  [Amazon recommends this](https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_UpgradeDBInstance.PostgreSQL.html)
-  as part of a major version upgrade.
+- If a PostgreSQL version is specified with `postgresql['version']` that doesn't ship
+  with that Omnibus GitLab release, the
+  [default version in the compatibility table](https://docs.gitlab.com/ee/administration/package_information/postgresql_versions.html)
+  determines which client binaries (such as the PostgreSQL backup/restore binaries) are active.
 
 The following example demonstrates upgrading from a database host running PostgreSQL 12 to another database host running PostgreSQL 13 and incurs downtime:
 
@@ -986,6 +986,20 @@ when your installation is using PgBouncer.
    sudo gitlab-ctl start
    ```
 
+1. After a upgrading PostgreSQL to a new major release:
+
+   - With Amazon RDS ([as recommended by AWS](https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_UpgradeDBInstance.PostgreSQL.html)), or
+   - If the database server is running very high (near 100%) CPU utilization.
+
+   Recreating the table statistics will ensure efficient query plans are picked
+   and reduce database server CPU load.
+
+   Run the following query on the PostgreSQL database console:
+
+   ```SQL
+   SET statement_timeout = 0; ANALYZE VERBOSE;
+   ```
+
 ### Seed the database (fresh installs only)
 
 WARNING:

doc/settings/nginx.md

@@ -774,3 +774,21 @@ If you get this error, check your NGINX configuration file if you have a trailin
    ```shell
    sudo systemctl restart nginx
    ```
+
+### GitLab is presenting 502 errors and `worker_connections are not enough` in logs
+
+If you get a `worker_connections are not enough` error in the logs, configure the NGINX worker connections to a higher value:
+
+1. Edit `/etc/gitlab/gitlab.rb`:
+
+   ```ruby
+   gitlab['nginx']['worker_connections'] = 10240
+   ```
+
+1. Reconfigure GitLab:
+
+   ```shell
+   sudo gitlab-ctl reconfigure
+   ```
+
+The default value is [10240 connections](https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/86f98401113eb843658b63d45d58be8b706216f3/files/gitlab-cookbooks/gitlab/attributes/default.rb#L750).

files/gitlab-config-template/gitlab.rb.template

@@ -116,7 +116,6 @@ external_url 'GENERATED_EXTERNAL_URL'
 # gitlab_rails['gitlab_email_smime_ca_certs_file'] = '/etc/gitlab/ssl/gitlab_smime_cas.crt'
 
 ### GitLab user privileges
-# gitlab_rails['gitlab_default_can_create_group'] = true
 # gitlab_rails['gitlab_username_changing_enabled'] = true
 
 ### Default Theme

files/gitlab-cookbooks/gitlab/attributes/default.rb

@@ -88,7 +88,6 @@ default['gitlab']['gitlab-rails']['gitlab_email_smime_enabled'] = false
 default['gitlab']['gitlab-rails']['gitlab_email_smime_key_file'] = '/etc/gitlab/ssl/gitlab_smime.key'
 default['gitlab']['gitlab-rails']['gitlab_email_smime_cert_file'] = '/etc/gitlab/ssl/gitlab_smime.crt'
 default['gitlab']['gitlab-rails']['gitlab_email_smime_ca_certs_file'] = nil
-default['gitlab']['gitlab-rails']['gitlab_default_can_create_group'] = nil
 default['gitlab']['gitlab-rails']['gitlab_username_changing_enabled'] = nil
 default['gitlab']['gitlab-rails']['gitlab_default_theme'] = nil
 default['gitlab']['gitlab-rails']['gitlab_default_projects_features_issues'] = nil

files/gitlab-cookbooks/gitlab/templates/default/gitlab.yml.erb

@@ -80,7 +80,6 @@ production: &base
     # Email server smtp settings are in [a separate file](initializers/smtp_settings.rb.sample).
 
     ## User settings
-    default_can_create_group: <%= @gitlab_default_can_create_group %>  # default: true
     username_changing_enabled: <%= @gitlab_username_changing_enabled %> # default: true - User can change her username/namespace
     ## Default theme
     ##   1 - Graphite

files/gitlab-cookbooks/package/libraries/deprecations.rb

@@ -287,25 +287,25 @@ module Gitlab
           {
             config_keys: %w(gitaly cgroups_count),
             deprecation: '15.1',
-            removal: '16.0', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
+            removal: '16.1', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
             note: "Use `gitaly['cgroups_repositories_count']` instead."
           },
           {
             config_keys: %w(gitaly cgroups_memory_enabled),
             deprecation: '15.1',
-            removal: '16.0', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
+            removal: '16.1', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
             note: "Use `gitaly['cgroups_memory_bytes'] or gitaly['cgroups_repositories_memory_bytes'] instead."
           },
           {
             config_keys: %w(gitaly cgroups_memory_limit),
             deprecation: '15.1',
-            removal: '16.0', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
+            removal: '16.1', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
             note: "Use `gitaly['cgroups_memory_bytes'] or gitaly['cgroups_repositories_memory_bytes'] instead."
           },
           {
             config_keys: %w(gitaly cgroups_cpu_enabled),
             deprecation: '15.1',
-            removal: '16.0', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
+            removal: '16.1', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6828
             note: "Use `gitaly['cgroups_cpu_shares'] or gitaly['cgroups_repositories_cpu_shares'] instead."
           },
           {
@@ -317,7 +317,7 @@ module Gitlab
           {
             config_keys: %w(praefect separate_database_metrics),
             deprecation: '15.5',
-            removal: '16.0', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7072
+            removal: '16.1', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7072
             note: "Starting with GitLab 16.0, Praefect DB metrics will no longer be available on `/metrics` and must be scraped from `/db_metrics`."
           },
           {
@@ -403,7 +403,7 @@ module Gitlab
           {
             config_keys: ['praefect', key],
             deprecation: '15.9',
-            removal: '16.0', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7438
+            removal: '16.1', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7438
             note: "In GitLab 15.9, Praefect's configuration in Omnibus GitLab was changed to structurally match Praefect's own configuration. Please see the migration instructions at https://docs.gitlab.com/ee/update/#1590"
           }
         end
@@ -462,7 +462,7 @@ module Gitlab
           {
             config_keys: ['gitaly', key],
             deprecation: '15.10',
-            removal: '16.0', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7439
+            removal: '16.1', # https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7439
             note: "In GitLab 15.10, Gitaly's configuration in Omnibus GitLab was changed to structurally match Gitaly's own configuration. Please see the migration instructions at https://docs.gitlab.com/ee/update/#15100"
           }
         end