Change listen_addr default to nil

- Per review discussin, change the workhorse listen_addr default to nil

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

files/gitlab-cookbooks/gitlab/attributes/default.rb

@@ -610,7 +610,7 @@ default['gitlab']['gitlab-workhorse']['ha'] = false
 default['gitlab']['gitlab-workhorse']['listen_network'] = "unix"
 default['gitlab']['gitlab-workhorse']['listen_umask'] = 000
 default['gitlab']['gitlab-workhorse']['sockets_directory'] = "/var/opt/gitlab/gitlab-workhorse/sockets"
-default['gitlab']['gitlab-workhorse']['listen_addr'] = "/var/opt/gitlab/gitlab-workhorse/sockets/socket"
+default['gitlab']['gitlab-workhorse']['listen_addr'] = nil
 default['gitlab']['gitlab-workhorse']['auth_backend'] = "http://localhost:8080"
 default['gitlab']['gitlab-workhorse']['auth_socket'] = nil
 default['gitlab']['gitlab-workhorse']['cable_backend'] = "http://localhost:8280"

files/gitlab-cookbooks/gitlab/libraries/helpers/gitlab_workhorse_helper.rb

@@ -6,7 +6,11 @@ class GitlabWorkhorseHelper < BaseHelper
   def socket_file_name
     return unless unix_socket?
 
-    File.basename(node['gitlab']['gitlab-workhorse']['listen_addr'])
+    file_path = node['gitlab']['gitlab-workhorse']['listen_addr']
+
+    return File.basename(file_path) unless file_path.nil?
+
+    'socket'
   end
 
   def sockets_directory