refactor: add type annotations to base_model_provider_handler
What does this merge request do and why?
Adds type annotations to BaseModelProviderHandler
.
Addresses the following discussion !1839 (comment 2296506949)
Merge request checklist
-
Tests added for new functionality. If not, please raise an issue to follow up. -
Documentation added/updated, if needed.
Merge request reports
Activity
changed milestone to %17.9
assigned to @ck3g
added Category:Code Suggestions label
Reviewer roulette
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @mikeeddington
(UTC-8, 9 hours behind author)
@alejandro
(UTC+0, 1 hour behind author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****- Resolved by Stephan Rayner
@srayner @achueshev could you please review this change? Thank you
requested review from @achueshev and @srayner
started a merge train
mentioned in commit 884ec8a1