An error occurred while fetching this tab.
refactor: pass in config as dependency instead of self initializing
- Jan 11, 2025
-
-
Leaminn Ma authored
-
In !1590 (merged), we introduced the region
field to the Snowplow context. It is currently resolved by directly instantiating Config
. It was noted in !1590 (comment 2205752321) that this has an undesirable side effect (ie. reading .env
file).
This MR addresses the suggestion in !1590 (comment 2205904796) to refactor the code so that config
is passed in as a dependency argument.
Resolves #739 (closed).