Follow-up from "feat: add region telemetry data to code suggestions"
The following discussion from !1590 (merged) should be addressed:
-
@tle_gitlab started a discussion: (+4 comments)
suggestion: Self initialisation of the
Config
object involves a side-effect, ie. reading.env
file and I don't think this is desirable. Could we pass eitherconfig
orregion
as an argument to this function?
Proposal
Apply the suggested refactor from !1590 (comment 2205904796).
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Missy Davies added groupcode creation label
added groupcode creation label
- 🤖 GitLab Bot 🤖 added Category:Code Suggestions devopscreate sectiondev labels
added Category:Code Suggestions devopscreate sectiondev labels
- Matt Nohr added to epic gitlab-org&13082
added to epic gitlab-org&13082
- Matt Nohr changed epic to gitlab-org&16093
changed epic to gitlab-org&16093
- Missy Davies mentioned in issue gitlab-org/create-stage#13236 (closed)
mentioned in issue gitlab-org/create-stage#13236 (closed)
- Jordan Janes changed milestone to %17.8
changed milestone to %17.8
- Jordan Janes added typefeature label
added typefeature label
- Jordan Janes added code-creation-prioritylow label
added code-creation-prioritylow label
Adding the Deliverable label to say we will be committing to this issue during the assigned milestone. See the prodcut development flow handbook page for more details.
- Matt Nohr added Deliverable label
added Deliverable label
- Matt Nohr added workflowrefinement label
added workflowrefinement label
- Shola Quadri assigned to @squadri
assigned to @squadri
- Shola Quadri unassigned @squadri
unassigned @squadri
- Maintainer
This issue is scheduled for completion in this milestone but doesn't have an assignee. Changing health status to 'needs attention'.
Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to needs attention
changed health status to needs attention
- Maintainer
This issue is scheduled for completion in this milestone but doesn't have an assignee. Changing health status to 'at risk'.
Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to at risk
changed health status to at risk
- Jordan Janes mentioned in issue gitlab-org/create-stage#13243 (closed)
mentioned in issue gitlab-org/create-stage#13243 (closed)
- Leaminn Ma assigned to @lma-git
assigned to @lma-git
- Leaminn Ma changed the description
Compare with previous version changed the description
- Developer
I just moved this to workflowready for development today. Though it's small, it won't make the %17.8 cutoff.
Rolling this over to %17.9 and applying label missed-deliverable missed:17.8 cc: @jordanjanes @mnohr
1 - Leaminn Ma changed milestone to %17.9
changed milestone to %17.9
- Leaminn Ma added missed-deliverable missed:17.8 workflowready for development labels and removed workflowrefinement label
added missed-deliverable missed:17.8 workflowready for development labels and removed workflowrefinement label
- Leaminn Ma set weight to 1
set weight to 1
- Leaminn Ma removed health status at risk
removed health status at risk
- Leaminn Ma added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Leaminn Ma added maintenancerefactor typemaintenance labels and removed typefeature label
added maintenancerefactor typemaintenance labels and removed typefeature label
- Leaminn Ma mentioned in merge request !1823 (merged)
mentioned in merge request !1823 (merged)
- Leaminn Ma added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Maintainer
Setting health status to
needs attention
as this item slipped the previous milestone.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to needs attention
changed health status to needs attention
- Bruno Cardoso closed with merge request !1823 (merged)
closed with merge request !1823 (merged)
- Bruno Cardoso mentioned in commit ebf89a49
mentioned in commit ebf89a49
- Developer
Async Status Update 2025-01-14
-
Progress & Status:
- This was just a small refactor issue to decouple the Config class from our API endpoints in AIGW. This improves code maintainability moving forward.
- It's merged and deployed now.
- Next Steps:
- Blockers:
-
How confident are you that this will make it to the current milestone?
- Not confident
- Slightly confident
- Very confident
/cc @mnohr @jordanjanes
-
Progress & Status:
- Leaminn Ma added workflowcomplete label and removed workflowin review label
added workflowcomplete label and removed workflowin review label