Skip to content

Add metadata to metrics and events

Problem to solve

We would like to be able to break down metrics/logs based on client metadata.

Proposal

Client type (grpc / websockets)

Client Version (language server version, etc)

  • Pass X-Gitlab-Language-Server-Version from language server.
  • Forward X-Gitlab-Language-Server-Version header in websocket to gRPC metadata @halilcoban MR
  • Add lsp_version to prometheus metrics @halilcoban MR
  • Add lsp_version to runwway dashboard definiton @halilcoban
  • Add lsp_version type to DWS logs @shinya.maeda
  • Add lsp_version type to internal events @Joey_Khabie

GitLab Version

User Agent

  • Pass correct user agent in Language Server @shinya.maeda MR
  • Pass correct user agent in Workhorse @shinya.maeda MR
  • Pass correct user agent in Go executor @shinya.maeda MR
  • User agent won't be added to Prometheus metrics due to concern of cardinality.

Further details

Links / references

Edited by Halil Coban