## Why The DAP Impact v1 dashboard's Work tab has an "MR cycle time: median and p75, Duo vs non-Duo" panel (https://gitlab.com/groups/gitlab-org/-/work_items/23421#note_3831450220). The MergeRequests aggregation engine now exposes what it needs - https://gitlab.com/gitlab-org/gitlab/-/work_items/608191 (closed, 19.5) added: - `createdByDuo: Boolean` dimension on `MergeRequestsAggregationResponseDimensions` - whether the merge request was created by a GitLab Duo session - `createdByDuo: [Boolean!]` filter argument on `analytics.mergeRequests` - `acceptanceRate: Float` metric on `MergeRequestsAggregationResponse` - "Share of merge requests that were merged" (merged / total in scope; with `createdByDuo = true` it is the "Agent MR acceptance rate" the dashboard wants, per https://gitlab.com/gitlab-org/gitlab/-/merge_requests/254727) The GLQL MergeRequests analytics source (`src/analyzer/sources/merge_requests/analytics.rs`) has none of the three. Everything else the panel needs already compiles: `timeToMergeQuantile(0.5) as "median", timeToMergeQuantile(0.75) as "p75"` with the `merged` date filter. ## What Add to the MergeRequests analytics source: - `createdByDuo` as a dimension (and sort field) - `createdByDuo` as a filter (`createdByDuo = true`) - `acceptanceRate` as a metric (and sort field), since it ships in the same engine change ## How - Add a `CreatedByDuo` variant to `Field` in `src/types/field.rs` - `AcceptanceRate` already exists (CodeSuggestions uses it, GraphQL name `acceptanceRate`), reuse it - `valid_filter_fields()`, `valid_dimensions()`, `valid_sort_fields()`, `valid_metrics()` in `merge_requests/analytics.rs` - `field_type()`: `BooleanLike.with_ops([Equal])` - `BooleanLike` alone admits `!=` too (`src/analyzer/field_type.rs`). The engine argument is a list, so the value renders as `createdByDuo: [true]` - one-element list wrap in `graphql_filter_value`, same idea as the `[String!]` filters on this source, but a Bool-aware one: the transformer normalises boolean-like values to `Value::Bool` and `string_list_filter_value` passes `Bool` through unchanged - This is the first Boolean dimension on an analytics source. The transform already passes scalar dimension values through, but check the presenter side renders `true`/`false` sensibly in tables and as a chart series label - Regenerate `src/schema/schema.json`, add codegen + transform tests; the docs table lives in gitlab-org/gitlab (`doc/user/glql/data_sources/merge_request_analytics.md`), so that is a follow-up MR after release + bump ## Example ```yaml mode: analytics query: type = MergeRequest and group = "my-group" and merged > -30d dimensions: createdByDuo metrics: timeToMergeQuantile(0.5) as "median", timeToMergeQuantile(0.75) as "p75" ``` Target GraphQL: ```graphql mergeRequests(metricMergedAtFrom: "...") { aggregated { nodes { dimensions { createdByDuo } timeToMerge { timeToMergeQuantile_quantile_0_d5: quantile(quantile: 0.5) } timeToMerge { timeToMergeQuantile_quantile_0_d75: quantile(quantile: 0.75) } } } } ``` (`merged > -30d` renders only the `From` bound; the `median` / `p75` user aliases are applied by the transform, not in the query - the selection aliases are the generated slugs.) Returns two rows, `createdByDuo: true` and `createdByDuo: false`. ## References - Work tab query list and GLQL scan: https://gitlab.com/groups/gitlab-org/-/work_items/23421#note_3831450220 - Engine change: https://gitlab.com/gitlab-org/gitlab/-/work_items/608191 - Tracking: https://gitlab.com/gitlab-org/glql/-/issues/188 - Sibling DAP Impact GLQL issues: #206, #207, #209