Operator is creating ConfigMap with the wrong name (if CR has label app.kubernetes.io/instance set)
Hi all,
We're deploying our gitlab runners via ArgoCD (helm in the background), which means that the runner CR has the label app.kubernetes.io/instance
set.
During the creation of the labels, the label app.kubernetes.io/instance
should be set to: CR-Name + "-runner". However on the next few lines, this label is overwritten, if the CR has already a label set. In my case, the label comes from helm which deployed the runner CR.
The ConfigMap receives therefore an invalid name. During the creation of the VolumeMounts of the Deployment, the name of the ConfigMap is hardcoded, which leads to an invalid configuration of the deployments.
Therefore deploying a Gitlab Runner with helm is currently not possible.
I would propose to delete the reflect.deepequal part during the Label creation. I haven't checked the whole code if there are any needs for this, but in my opinion this just leads to an unecessary risk of a bug.