Skip to content

Add more Editors and Selectors for Helm facility

Hossein Pursultani requested to merge 15-more-selectors-editors into master

This MR introduces more ObjectSelector and ObjectEditor helper functions. There are three categories of functions:

  1. XyzSelector variables that are ObjectSelector functions for Xyz resource type.
  2. NewXyzSelector helper functions that build an ObjectSelector which ensure the resource type is Xyz and passes it to a delegate function for further checks, e.g. inspecting .ObjectMeta.Labels or .Spec.
  3. NewXyzEditor helper functions that build an ObjectEditor for Xyz resource type and passes its reference to a delegate function for editing.

This MR also change the signature of EditObjects function and removes the selector. With the new NewZyzEditor functions, the editor function satisfies both requirements.

The last change in this MR was using HELM_NAMESPACE environment variable in tests against a non-default namespace.

Closes #15 (closed)

Edited by Hossein Pursultani

Merge request reports