Resolve "Not logged in view on threaded conversations"
Closes #2206 (closed)
Blocked by:
- https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1652 (only locally)
- https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1634
Affected by:
Not member | Not logged in |
---|---|
Testing strategy
Since the !1652 (merged) hasn't been merged yet, you need to apply following patch locally to enable local anonymous API.
diff --git a/server/web/express.js b/server/web/express.js
index b856852af..2f0d51307 100644
--- a/server/web/express.js
+++ b/server/web/express.js
@@ -125,7 +125,6 @@ module.exports = {
app.use(passport.initialize());
app.use(passport.session());
- app.use(require('./middlewares/authenticate-bearer'));
app.use(rememberMe.rememberMeMiddleware);
app.use(require('./middlewares/rate-limiter'));
app.use(require('./middlewares/record-client-usage-stats'));
I don't know why the diff highlighting doesn't work, the line that requires authenticate-bearer
should be removed
- Test that anonymous user can open a thread
- they shouldn't see chat input or chat item actions
- no message should be highlighted as unread
- Test that user who is not a member of a room can't see the chat message input
- they should see the chat item actions because eventually the will be able to "Report" a message
Unread logic
- have two users logged in and validate that when a user creates a message, the other one has the message highlighted as unread
- validate that read chat messages are not shown as unread
Edited by Tomas Vik (OOO back on 2024-05-09)