Skip to content

Fix "Thread message feed not showing when user isn't room member"

Tomas Vik requested to merge 2343-add-current-room-to-state into develop

Closes #2343 (closed)

When the user wasn't a member of a room the initial roomMap in the state missed the current room because the Map was only populated by the restful.serializeTroupesForUser(userId).

The displayedRoom getter is used in our Vue code to generate permalinks for messages.

Note: Hiding the thread message input box is going to be implemented in https://gitlab.com/gitlab-org/gitter/webapp/issues/2206

before after
Kapture_2019-11-11_at_15.07.40 Kapture_2019-11-11_at_15.06.33

Testing strategy:

  1. Visit a room with threaded messages that you are not a member of
  2. Open a message thread
  3. Observe thread messages being present

Merge request reports