Skip to content

Fix SPA room switcher to always just fallback to redirecting the window (navigation, history)

Eric Eastwood requested to merge 2181-2170-2171-2179-fix-spa-room-switcher-to-always-fallback-to-just-redirecting into develop

Fix SPA room switcher to always just fallback to redirecting the window (navigation, history, popstate, pushstate)

Fixes all of the history, navigation, redirection issues we were seeing

Fix https://gitlab.com/gitlab-org/gitter/webapp/issues/2181, https://gitlab.com/gitlab-org/gitter/webapp/issues/2170, https://gitlab.com/gitlab-org/gitter/webapp/issues/2171, https://gitlab.com/gitlab-org/gitter/webapp/issues/2179

Previous MR where we touched the SPA room switcher, https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1428

Testing strategy

  1. Add the feature toggle, node ./scripts/utils/feature-toggle.js --name vue-left-menu --description "Left menu using Vue (alpha)"
  2. Enable the feature toggle

https://gitlab.com/gitlab-org/gitter/webapp/issues/2181

  1. Visit a room
  2. Click on the globe to go to the community/org home
  3. Press back, and notice you are back in the room with the URL updated

https://gitlab.com/gitlab-org/gitter/webapp/issues/2170

  1. Visit a room
  2. Delete the room
  3. Notice how you are redirected to the userhome /home

https://gitlab.com/gitlab-org/gitter/webapp/issues/2171

  1. Visit a room
  2. Leave the room
  3. Notice how you are redirected to the userhome /home

https://gitlab.com/gitlab-org/gitter/webapp/issues/2179

  1. Visit a room where another user has chatted
  2. In the user popover, click the "Chat privately" option
  3. Notice how you are redirected to chatting with that user
Edited by Eric Eastwood

Merge request reports