GitHub linked Community Avatar won't update
Currently, when I upload a new avatar for the room, the existing avatar gets a loading bar underneath of it, which progresses to 100%. After the bar finishes, the page re-renders... and the old avatar remains.
avatarCheckedDate
:
Issue 1: -
https://gitlab.com/gitlab-org/gitter/webapp/blob/baf37c43103cd1632c53f9d26c94eb66e0b10bbc/modules/groups/lib/group-avatars.js#L84
-
group.avatarCheckedDate - Date.now() > AVATAR_VERSION_CHECK_TIMEOUT
is never going to be true (date in a past minus now is going to be negative number every time
-
Issue 2: The avatar upload shouldn't be enabled for GitHub communities
The canChangeGroupAvatar
flag in headerView.js
is true if the user is admin of the community. This is an issue for communities linked to GitHub where the avatar is taken from the GitHub Org and the upload is not used which is confusing users.
Note: Issue 2 moved into a separate issue #2301
TODO:
-
when does the group.avatarVersion
get updated?
Edited by Tomas Vik