Documentation for manual GitHub integration setup is out-of-date - service hooks -> webhooks
In Gitter, when the following the link for configuring new integrations,
If one proceeds to instructions for GitHub,
and goes to instructions for manual setup, the instructions are out of date:
They probably need to be replaced with instructions for webhooks.
GitHub integration activity has stopped working for some people
It's probably related to the following but plenty of other rooms are still working fine,
January 31, 2019: GitHub will stop delivering installed services' events on GitHub.com.
https://developer.github.com/v3/guides/replacing-github-services/#deprecation-timeline
Reports:
-
☝ January 8, 2019 3:04 PM -
☝ January 10, 2019 7:30 PM -
☝ February 16, 2019 6:54 AM -
☝ February 18, 2019 12:01 PM - https://gitter.zendesk.com/agent/tickets/10249
- https://gitlab.com/gitlab-org/gitter/webapp/issues/2097
-
☝ March 5, 2019 7:12 AM - https://twitter.com/DanTup/status/1104093938007359494
- https://twitter.com/technicalissues/status/1221673104507908096
Workaround
Room settings dropdown -> Integrations -> GitHub -> Configure manually
Now on GitHub's side, visit https://github.com/<owner>/<repo>/settings/hooks. Here is what the fields should look like on GitHub for manual webhook setup,
- Payload URL: https://webhooks.gitter.im/e/xxx
- Where
xxxis the token from Gitter. You can also pressDoneon the Gitter configure step and get the full URL from the list of integrations
- Where
- Content-type: application/json
- Secret: N/A (no secret)
Relevant code
- https://gitlab.com/gitlab-org/gitter/gitter-webhooks-handler/blob/b725f5b36f8e709ac792ea5da894febcaacbe370/services/views/auth/pop-up-parent.pug#L52-63
- https://gitlab.com/gitlab-org/gitter/webapp/blob/develop/docs/integrations.md
Gitter discussion: