Create room modal populates the community input with current room's community regardless of permissions
Problem
Currently, if the user is in a room, some-community/some-room
, and clicks Add a room, the community will be set
to some-community
regardless of the permissions they have. This leads to silent failure (and JS errors in the dev-tools console).
Some errors you see in the devtools console
vendor.js:14 Uncaught TypeError: Cannot read property 'get' of undefined.
...
vendor.js:14 Uncaught Error: A group needs to be selected in order to create a room
...
router-app.js:4 Uncaught TypeError: Cannot read property 'get' of undefined
...
Potential solutions
It would be preferable to leave the box blank if the user does not have enough permissions.
The user needs to run through these steps if they actually have permissions on GitHub https://gitlab.com/gitlab-org/gitter/webapp/blob/develop/docs/faq.md#why-isnt-my-github-organisation-or-repos-appearing
Tags for searching
- Ensure admin before auto-selecting community
- Add a room dialog
Edited by Eric Eastwood