You need to sign in or sign up before continuing.
Remove client_id/client_secret query parameter usage from GitHub API authentication
Remove client_id/client_secret query parameter usage from GitHub API authentication
Fix https://gitlab.com/gitlab-org/gitter/webapp/-/issues/2442
- https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
- https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
Testing strategy
- Start the app with debugging for the GitHub public token pool enabled -> for macOS/Linux:
DEBUG=gitter:app:github:public-token-pool npm start
, for Windows:set DEBUG=gitter:app:github:public-token-pool&&npm start
- Paste a GitHub commit link in one of your rooms, ex. https://github.com/gitterHQ/sidecar/commit/ae2e261d86b8f0d2cc2fb3c92fb3a7e7c6f92617
- Open an incognito browser and view the room
- Hover the decorated commit link and notice you can see the content for the commit as well as
github.anonymous.access
logged in the CLI window for the server
Todo
-
Update tentacles
-
Fix request-http-cache
Edited by Eric Eastwood