Skip to content

Fix failing tests

Eric Eastwood requested to merge fix-failing-tests into master

.

  • Fix failing tests
    • client-long-polling -> lib/transport/base-long-polling-transport.js
      • Use explicit outage and restore commands instead of race-condition rampant restart
      • Remove the defer pattern and use straight promises
    • test/client-shutdown-test.js
      • Remove wtfnode dependency which is borked and not used to test anything
  • Add --grep option so we can run individual Mocha tests, npm test -- --grep "client-long-polling proxied client-bad-connection should emit connection events"

Failing tests:

1) node-test-suite integration tests client-long-polling proxied client-bad-connection should emit connection events:
   Error: timeout of 20000ms exceeded. Ensure the done() callback is being called in this test.
    at Timeout.<anonymous> (C:\Users\MLM\Documents\GitLab\halley\node_modules\mocha\lib\runnable.js:226:19)

2) node-test-suite integration tests client-shutdown-test should cleanup after disconnect on subscribe:

    Uncaught AssertionError [ERR_ASSERTION]: 1 === 0
    + expected - actual

    -1
    +0

    at ChildProcess.<anonymous> (C:\Users\MLM\Documents\GitLab\halley\test\client-shutdown-test.js:16:14)
    at maybeClose (internal/child_process.js:897:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:208:5)

3) node-test-suite integration tests client-shutdown-test should cleanup after disconnect on no messages:

    Uncaught AssertionError [ERR_ASSERTION]: 1 === 0
    + expected - actual

    -1
    +0

    at ChildProcess.<anonymous> (C:\Users\MLM\Documents\GitLab\halley\test\client-shutdown-test.js:26:14)
    at maybeClose (internal/child_process.js:897:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:208:5)

Fix https://gitlab.com/gitlab-org/gitter/halley/issues/4

Edited by Eric Eastwood

Merge request reports