Skip to content

Fix NPE when matching a link without pathname

Eric Eastwood requested to merge 10-fix-npe-with-no-pathname into master

Fix NPE when matching a link without pathname

https://sentry.gitlap.com/gitlab/gitter-backend/issues/512343 (public Sentry: https://sentry.gitlap.com/share/issue/c5e2e515d4054a678d5d38f7549fa567/)

Cannot read property 'match' of null

Relevant code: https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/blob/14b4ff6cc98278ee8117da32ca311cb4ba8734ac/lib/decoration-url-matcher.js#L26

This can happen when someone tries to link to nothing

Coveralls [foo/bar]() (master) `0.0%`

Or when you link with just host/port

[foo](localhost:1234)

https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/issues/10

Fix https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/issues/10

Edited by Eric Eastwood

Merge request reports