Can directly add approvers to approval rule

- remove add button
- no more pillbox
- approvers will be automatically added when selected
173 jobs for !18965 with 30695-remove-add-btn-in-approval-rule in 120 minutes and 36 seconds (queued for 6 seconds)
detached
Status Job ID Name Coverage
  Prepare
passed #329448130
docker gitlab-org
build-qa-image

00:05:29

passed #329448127
gitlab-org
compile-assets pull-cache

00:07:26

passed #329448128
gitlab-org
compile-assets pull-cache foss

00:05:55

passed #329448132
retrieve-tests-metadata

00:01:58

passed #329448131
gitlab-org
review-cleanup-failed-deployment

00:00:21

passed #329448129
gitlab-org
setup-test-env

00:05:42

 
  Test
passed #329448149
allowed to fail
code_quality

00:11:18

passed #329448300
gitlab-org
danger-review

00:02:30

passed #329448291
gitlab-org
db:check-schema

00:03:02

passed #329448292
gitlab-org
db:migrate-from-v11.11.0

00:10:31

passed #329448290
gitlab-org
db:migrate:reset

00:03:22

passed #329448294
gitlab-org
db:rollback

00:03:37

passed #329448299
gitlab-org
db:rollback geo

00:02:59

passed #329448153
allowed to fail
dependency_scanning

00:10:41

passed #329448289
gitlab-org
downtime_check

00:02:24

passed #329448133
docker gitlab-org
gitlab:assets:compile pull-cache

00:20:47

passed #329448296
gitlab-org
gitlab:setup

00:03:22

passed #329448301
gitlab-org
gitlab_git_test

00:00:23

passed #329448136
gitlab-org
jest

00:20:18

passed #329448137
gitlab-org
jest-foss

00:17:16

passed #329448134
gitlab-org
karma

00:21:00

67.7%
passed #329448135
gitlab-org
karma-foss

00:15:23

passed #329448143
gitlab-org
memory-on-boot

00:06:42

passed #329448142
gitlab-org
memory-static

00:04:26

passed #329448139
gitlab-org
qa-frontend-node:10

00:15:59

passed #329448138
gitlab-org
qa-frontend-node:8

00:22:10

passed #329448140
gitlab-org allowed to fail
qa-frontend-node:latest

00:22:02

passed #329448144
gitlab-org
qa:internal

00:01:58

passed #329448145
gitlab-org
qa:selectors

00:01:43

passed #329448147
gitlab-org
qa:selectors-foss

00:01:56

passed #329448287
gitlab-org
rspec fast_spec_helper

00:03:45

passed #329448198
gitlab-org
rspec integration pg9 1/6

00:17:11

passed #329448199
gitlab-org
rspec integration pg9 2/6

00:16:29

passed #329448200
gitlab-org
rspec integration pg9 3/6

00:20:13

passed #329448201
gitlab-org
rspec integration pg9 4/6

00:19:18

passed #329448202
gitlab-org
rspec integration pg9 5/6

00:17:09

passed #329448203
gitlab-org
rspec integration pg9 6/6

00:17:57

passed #329448204
gitlab-org
rspec integration pg9-foss 1/6

00:18:38

passed #329448205
gitlab-org
rspec integration pg9-foss 2/6

00:18:47

passed #329448206
gitlab-org
rspec integration pg9-foss 3/6

00:15:15

passed #329448207
gitlab-org
rspec integration pg9-foss 4/6

00:16:07

passed #329448210
gitlab-org
rspec integration pg9-foss 5/6

00:15:45

passed #329448211
gitlab-org
rspec integration pg9-foss 6/6

00:17:03

passed #329448212
gitlab-org
rspec system pg9 1/24

00:15:56

passed #329448223
gitlab-org
rspec system pg9 10/24

00:15:57

passed #329448224
gitlab-org
rspec system pg9 11/24

00:12:52

passed #329448225
gitlab-org
rspec system pg9 12/24

00:12:13

passed #329448226
gitlab-org
rspec system pg9 13/24

00:14:00

passed #329448227
gitlab-org
rspec system pg9 14/24

00:15:01

passed #329448228
gitlab-org
rspec system pg9 15/24

00:18:00

passed #329448229
gitlab-org
rspec system pg9 16/24

00:11:43

passed #329448230
gitlab-org
rspec system pg9 17/24

00:16:17

passed #329448231
gitlab-org
rspec system pg9 18/24

00:13:31

passed #329448232
gitlab-org
rspec system pg9 19/24

00:12:51

passed #329448213
gitlab-org
rspec system pg9 2/24

00:13:54

passed #329448233
gitlab-org
rspec system pg9 20/24

00:14:10

passed #329448234
gitlab-org
rspec system pg9 21/24

00:13:45

passed #329448235
gitlab-org
rspec system pg9 22/24

00:11:58

passed #329448236
gitlab-org
rspec system pg9 23/24

00:12:16

passed #329448237
gitlab-org
rspec system pg9 24/24

00:13:06

passed #329448214
gitlab-org
rspec system pg9 3/24

00:11:36

passed #329448215
gitlab-org
rspec system pg9 4/24

00:14:02

passed #329448216
gitlab-org
rspec system pg9 5/24

00:13:33

passed #329448217
gitlab-org
rspec system pg9 6/24

00:14:13

passed #329448218
gitlab-org
rspec system pg9 7/24

00:11:51

passed #329448219
gitlab-org
rspec system pg9 8/24

00:14:30

passed #329448222
gitlab-org
rspec system pg9 9/24

00:16:25

passed #329448238
gitlab-org
rspec system pg9-foss 1/24

00:12:35

passed #329448249
gitlab-org
rspec system pg9-foss 10/24

00:12:24

passed #329448250
gitlab-org
rspec system pg9-foss 11/24

00:12:16

passed #329448251
gitlab-org
rspec system pg9-foss 12/24

00:12:06

passed #329448252
gitlab-org
rspec system pg9-foss 13/24

00:11:15

passed #329448253
gitlab-org
rspec system pg9-foss 14/24

00:13:04

passed #329448254
gitlab-org
rspec system pg9-foss 15/24

00:12:00

passed #329448255
gitlab-org
rspec system pg9-foss 16/24

00:13:25

passed #329448256
gitlab-org
rspec system pg9-foss 17/24

00:14:20

passed #329448257
gitlab-org
rspec system pg9-foss 18/24

00:11:01

passed #329448258
gitlab-org
rspec system pg9-foss 19/24

00:11:42

passed #329448239
gitlab-org
rspec system pg9-foss 2/24

00:11:33

passed #329448259
gitlab-org
rspec system pg9-foss 20/24

00:13:05

passed #329448260
gitlab-org
rspec system pg9-foss 21/24

00:14:26

passed #329448261
gitlab-org
rspec system pg9-foss 22/24

00:10:25

passed #329448262
gitlab-org
rspec system pg9-foss 23/24

00:12:11

passed #329448263
gitlab-org
rspec system pg9-foss 24/24

00:14:41

passed #329448240
gitlab-org
rspec system pg9-foss 3/24

00:12:48

passed #329448241
gitlab-org
rspec system pg9-foss 4/24

00:15:14

passed #329448242
gitlab-org
rspec system pg9-foss 5/24

00:11:11

passed #329448243
gitlab-org
rspec system pg9-foss 6/24

00:12:58

passed #329448244
gitlab-org
rspec system pg9-foss 7/24

00:11:37

passed #329448246
gitlab-org
rspec system pg9-foss 8/24

00:12:21

passed #329448247
gitlab-org
rspec system pg9-foss 9/24

00:15:01

passed #329448154
gitlab-org
rspec unit pg9 1/20

00:18:17

passed #329448163
gitlab-org
rspec unit pg9 10/20

00:18:52

passed #329448164
gitlab-org
rspec unit pg9 11/20

00:17:16

passed #329448165
gitlab-org
rspec unit pg9 12/20

00:14:32

passed #329448166
gitlab-org
rspec unit pg9 13/20

00:16:40

passed #329448168
gitlab-org
rspec unit pg9 14/20

00:17:29

passed #329448170
gitlab-org
rspec unit pg9 15/20

00:18:28

passed #329448171
gitlab-org
rspec unit pg9 16/20

00:19:01

passed #329448172
gitlab-org
rspec unit pg9 17/20

00:14:30

passed #329448173
gitlab-org
rspec unit pg9 18/20

00:16:14

passed #329448174
gitlab-org
rspec unit pg9 19/20

00:15:58

passed #329448155
gitlab-org
rspec unit pg9 2/20

00:13:25

passed #329448175
gitlab-org
rspec unit pg9 20/20

00:20:09

passed #329448156
gitlab-org
rspec unit pg9 3/20

00:16:29

passed #329448157
gitlab-org
rspec unit pg9 4/20

00:17:13

passed #329448158
gitlab-org
rspec unit pg9 5/20

00:14:18

passed #329448159
gitlab-org
rspec unit pg9 6/20

00:12:58

passed #329448160
gitlab-org
rspec unit pg9 7/20

00:13:13

passed #329448161
gitlab-org
rspec unit pg9 8/20

00:18:37

passed #329448162
gitlab-org
rspec unit pg9 9/20

00:16:38

passed #329448176
gitlab-org
rspec unit pg9-foss 1/20

00:16:20

passed #329448185
gitlab-org
rspec unit pg9-foss 10/20

00:13:10

passed #329448186
gitlab-org
rspec unit pg9-foss 11/20

00:17:41

passed #329448187
gitlab-org
rspec unit pg9-foss 12/20

00:14:02

passed #329448188
gitlab-org
rspec unit pg9-foss 13/20

00:16:43

passed #329448189
gitlab-org
rspec unit pg9-foss 14/20

00:15:21

passed #329448190
gitlab-org
rspec unit pg9-foss 15/20

00:15:00

passed #329448193
gitlab-org
rspec unit pg9-foss 16/20

00:18:31

passed #329448194
gitlab-org
rspec unit pg9-foss 17/20

00:13:48

passed #329448195
gitlab-org
rspec unit pg9-foss 18/20

00:13:48

passed #329448196
gitlab-org
rspec unit pg9-foss 19/20

00:19:33

passed #329448177
gitlab-org
rspec unit pg9-foss 2/20

00:11:24

passed #329448197
gitlab-org
rspec unit pg9-foss 20/20

00:14:32

passed #329448178
gitlab-org
rspec unit pg9-foss 3/20

00:14:27

passed #329448179
gitlab-org
rspec unit pg9-foss 4/20

00:14:52

passed #329448180
gitlab-org
rspec unit pg9-foss 5/20

00:16:07

passed #329448181
gitlab-org
rspec unit pg9-foss 6/20

00:13:38

passed #329448182
gitlab-org
rspec unit pg9-foss 7/20

00:12:37

passed #329448183
gitlab-org
rspec unit pg9-foss 8/20

00:15:20

passed #329448184
gitlab-org
rspec unit pg9-foss 9/20

00:14:44

passed #329448285
gitlab-org
rspec-ee integration pg10 geo

00:08:23

passed #329448271
gitlab-org
rspec-ee integration pg9 1/3

00:12:31

passed #329448272
gitlab-org
rspec-ee integration pg9 2/3

00:14:01

passed #329448273
gitlab-org
rspec-ee integration pg9 3/3

00:15:57

passed #329448281
gitlab-org
rspec-ee integration pg9 geo

00:07:07

passed #329448286
gitlab-org
rspec-ee system pg10 geo

00:07:47

passed #329448274
gitlab-org
rspec-ee system pg9 1/5

00:16:32

passed #329448275
gitlab-org
rspec-ee system pg9 2/5

00:17:35

passed #329448276
gitlab-org
rspec-ee system pg9 3/5

00:41:42

passed #329448277
gitlab-org
rspec-ee system pg9 4/5

00:15:30

passed #329448278
gitlab-org
rspec-ee system pg9 5/5

00:15:25

passed #329448282
gitlab-org
rspec-ee system pg9 geo

00:06:22

passed #329448283
gitlab-org
rspec-ee unit pg10 geo 1/2

00:14:14

passed #329448284
gitlab-org
rspec-ee unit pg10 geo 2/2

00:13:12

passed #329448264
gitlab-org
rspec-ee unit pg9 1/7

00:14:19

passed #329448265
gitlab-org
rspec-ee unit pg9 2/7

00:14:32

passed #329448266
gitlab-org
rspec-ee unit pg9 3/7

00:16:57

passed #329448267
gitlab-org
rspec-ee unit pg9 4/7

00:17:18

passed #329448268
gitlab-org
rspec-ee unit pg9 5/7

00:15:36

passed #329448269
gitlab-org
rspec-ee unit pg9 6/7

00:19:01

passed #329448270
gitlab-org
rspec-ee unit pg9 7/7

00:17:11

passed #329448279
gitlab-org
rspec-ee unit pg9 geo 1/2

00:14:43

passed #329448280
gitlab-org
rspec-ee unit pg9 geo 2/2

00:11:38

passed #329448151
allowed to fail
sast

00:10:10

failed #329448288
gitlab-org
static-analysis

00:17:55

passed #329448141
gitlab-org
webpack-dev-server

00:05:08

 
  Review Prepare
passed #329448303
review-build-cng

00:30:00

 
  Review
failed #329448305
gitlab-org allowed to fail
review-deploy

00:00:57

manual #329448307
gitlab-org allowed to fail manual
review-stop
 
  Qa
passed #329448314
allowed to fail
dast

00:06:58

failed #329448312
allowed to fail
package-and-qa

01:34:03

manual #329448310
allowed to fail manual
package-and-qa-manual
failed #329448331
docker gitlab-org allowed to fail
review-performance

00:07:03

manual #329448318
docker gitlab-org allowed to fail manual
review-qa-all 1/5
manual #329448321
docker gitlab-org allowed to fail manual
review-qa-all 2/5
manual #329448324
docker gitlab-org allowed to fail manual
review-qa-all 3/5
manual #329448327
docker gitlab-org allowed to fail manual
review-qa-all 4/5
manual #329448329
docker gitlab-org allowed to fail manual
review-qa-all 5/5
failed #329448315
docker gitlab-org allowed to fail
review-qa-smoke

00:08:19

 
  Post Test
skipped #329448333
gitlab-org
coverage
skipped #329448337
gitlab-org allowed to fail
flaky-examples-check
skipped #329448335
gitlab-org allowed to fail manual
parallel-spec-reports
 
Name Stage Failure
failed
package-and-qa Qa
Waiting for downstream pipeline status
............................................................................................../scripts/trigger-build:212:in `block in wait!': Pipeline did not succeed! (RuntimeError)
from ./scripts/trigger-build:201:in `loop'
from ./scripts/trigger-build:201:in `wait!'
from ./scripts/trigger-build:240:in `<main>'
Running after script...
$ date
Wed Oct 23 05:28:37 UTC 2019
ERROR: Job failed: exit code 1
failed
review-qa-smoke Qa
	 1: from /usr/local/lib/ruby/2.6.0/net/protocol.rb:191:in `readuntil'
/usr/local/lib/ruby/2.6.0/net/protocol.rb:217:in `rbuf_fill':
Net::ReadTimeout with #<TCPSocket:(closed)> (Net::ReadTimeout)
Running after script...
$ date
Wed Oct 23 04:33:53 UTC 2019
Uploading artifacts...
./qa/gitlab-qa-run-*: found 2 matching files
Uploading artifacts to coordinator... ok
id=329448315 responseStatus=201 Created token=Gbcsv9b_
ERROR: Job failed: exit code 1
failed
review-performance Qa
    at processImmediate [as _immediateCallback] (timers.js:722:5)
[2019-10-23 04:32:36] INFO: HTML stored in /sitespeed.io/sitespeed-results
[2019-10-23 04:32:36] INFO: Finished analysing https://gitlab-review-30695-remo-0gzoet.gitlab-review.app
Running after script...
$ mv sitespeed-results/data/performance.json performance.json
Uploading artifacts...
performance.json: found 1 matching files
Uploading artifacts to coordinator... ok
id=329448331 responseStatus=201 Created token=_1AxKJqc
ERROR: Job failed: exit code 1
failed
review-deploy Review
NAME                                              COMPLETIONS   DURATION   AGE
review-30695-remo-0gzoet-minio-create-buckets.1 0/1 28m 28m
Running after script...
$ date
Wed Oct 23 04:25:32 UTC 2019
Uploading artifacts...
review_app_url.txt: found 1 matching files
Uploading artifacts to coordinator... ok
id=329448305 responseStatus=201 Created token=7ohRMfGG
ERROR: Job failed: exit code 1
failed
static-analysis Test
✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.

Running after script...
$ date
Wed Oct 23 03:53:32 UTC 2019
ERROR: Job failed: exit code 1