Updates per review feedback

Update conan param description and fix missed refactored name
Add missing param, add authenticate_non_get
Update to properly handle and validate filename
146 jobs for !17798 with 13345-conan-file-download-endpoint in 74 minutes and 50 seconds (queued for 11 seconds)
detached
Status Job ID Name Coverage
  Prepare
passed #315100507
docker gitlab-org
build-qa-image

00:05:40

passed #315100502
gitlab-org
compile-assets pull-cache

00:07:32

passed #315100509
retrieve-tests-metadata

00:01:58

passed #315100508
gitlab-org
review-cleanup-failed-deployment

00:00:23

passed #315100503
gitlab-org
setup-test-env

00:07:18

 
  Test
passed #315100531
allowed to fail
code_quality

00:10:49

passed #315100686
gitlab-org
danger-review

00:02:44

passed #315100680
gitlab-org
db:check-schema

00:05:34

passed #315100681
gitlab-org
db:migrate-from-v11.11.0

00:10:15

passed #315100679
gitlab-org
db:migrate:reset

00:03:31

passed #315100682
gitlab-org
db:rollback

00:03:50

passed #315100685
gitlab-org
db:rollback geo

00:03:10

passed #315100533
allowed to fail
dependency_scanning

00:11:05

passed #315100678
gitlab-org
downtime_check

00:02:35

passed #315100510
docker gitlab-org
gitlab:assets:compile pull-cache

00:22:21

passed #315100684
gitlab-org
gitlab:setup

00:05:14

passed #315100687
gitlab-org
gitlab_git_test

00:02:10

passed #315100517
gitlab-org
jest

00:23:44

passed #315100518
gitlab-org
jest-foss

00:15:13

passed #315100515
gitlab-org
karma

00:20:41

67.77%
passed #315100516
gitlab-org
karma-foss

00:11:08

passed #315100530
gitlab-org
memory-on-boot

00:06:25

passed #315100529
gitlab-org
memory-static

00:05:56

passed #315100523
gitlab-org
qa-frontend-node:10

00:16:30

passed #315100522
gitlab-org
qa-frontend-node:8

00:20:14

passed #315100525
gitlab-org allowed to fail
qa-frontend-node:latest

00:20:55

passed #315100520
gitlab-org
qa:internal

00:02:49

passed #315100521
gitlab-org
qa:selectors

00:02:39

passed #315100676
gitlab-org
rspec fast_spec_helper

00:04:02

passed #315100593
gitlab-org
rspec integration pg9 1/6

00:18:58

passed #315100594
gitlab-org
rspec integration pg9 2/6

00:18:05

passed #315100595
gitlab-org
rspec integration pg9 3/6

00:18:10

passed #315100596
gitlab-org
rspec integration pg9 4/6

00:17:48

passed #315100597
gitlab-org
rspec integration pg9 5/6

00:17:41

passed #315100598
gitlab-org
rspec integration pg9 6/6

00:17:19

passed #315100599
gitlab-org
rspec integration pg9-foss 1/6

00:16:49

passed #315100600
gitlab-org
rspec integration pg9-foss 2/6

00:19:13

passed #315100601
gitlab-org
rspec integration pg9-foss 3/6

00:16:11

passed #315100602
gitlab-org
rspec integration pg9-foss 4/6

00:19:01

passed #315100605
gitlab-org
rspec integration pg9-foss 5/6

00:17:26

passed #315100606
gitlab-org
rspec integration pg9-foss 6/6

00:18:16

passed #315100609
gitlab-org
rspec system pg9 1/24

00:13:55

passed #315100619
gitlab-org
rspec system pg9 10/24

00:16:10

passed #315100620
gitlab-org
rspec system pg9 11/24

00:14:27

passed #315100621
gitlab-org
rspec system pg9 12/24

00:13:52

passed #315100622
gitlab-org
rspec system pg9 13/24

00:18:55

passed #315100623
gitlab-org
rspec system pg9 14/24

00:14:27

passed #315100624
gitlab-org
rspec system pg9 15/24

00:14:54

passed #315100625
gitlab-org
rspec system pg9 16/24

00:13:43

passed #315100630
gitlab-org
rspec system pg9 17/24

00:15:12

passed #315100632
gitlab-org
rspec system pg9 18/24

00:16:04

passed #315100633
gitlab-org
rspec system pg9 19/24

00:15:16

passed #315100610
gitlab-org
rspec system pg9 2/24

00:13:55

passed #315100634
gitlab-org
rspec system pg9 20/24

00:14:45

passed #315100635
gitlab-org
rspec system pg9 21/24

00:15:26

passed #315100638
gitlab-org
rspec system pg9 22/24

00:15:33

passed #315100639
gitlab-org
rspec system pg9 23/24

00:14:47

passed #315100641
gitlab-org
rspec system pg9 24/24

00:16:53

passed #315100611
gitlab-org
rspec system pg9 3/24

00:10:57

passed #315100612
gitlab-org
rspec system pg9 4/24

00:15:38

passed #315100614
gitlab-org
rspec system pg9 5/24

00:15:43

passed #315100615
gitlab-org
rspec system pg9 6/24

00:16:13

passed #315100616
gitlab-org
rspec system pg9 7/24

00:15:00

passed #315100617
gitlab-org
rspec system pg9 8/24

00:14:12

passed #315100618
gitlab-org
rspec system pg9 9/24

00:14:31

passed #315100534
gitlab-org
rspec unit pg9 1/20

00:17:30

passed #315100545
gitlab-org
rspec unit pg9 10/20

00:18:00

passed #315100546
gitlab-org
rspec unit pg9 11/20

00:17:06

passed #315100547
gitlab-org
rspec unit pg9 12/20

00:18:21

passed #315100548
gitlab-org
rspec unit pg9 13/20

00:16:34

passed #315100549
gitlab-org
rspec unit pg9 14/20

00:17:39

passed #315100550
gitlab-org
rspec unit pg9 15/20

00:19:09

passed #315100551
gitlab-org
rspec unit pg9 16/20

00:19:08

passed #315100552
gitlab-org
rspec unit pg9 17/20

00:15:53

passed #315100568
gitlab-org
rspec unit pg9 18/20

00:19:09

passed #315100569
gitlab-org
rspec unit pg9 19/20

00:16:32

passed #315100535
gitlab-org
rspec unit pg9 2/20

00:16:35

passed #315100570
gitlab-org
rspec unit pg9 20/20

00:15:05

passed #315100536
gitlab-org
rspec unit pg9 3/20

00:14:20

passed #315100537
gitlab-org
rspec unit pg9 4/20

00:16:36

passed #315100538
gitlab-org
rspec unit pg9 5/20

00:15:08

passed #315100539
gitlab-org
rspec unit pg9 6/20

00:18:10

passed #315100540
gitlab-org
rspec unit pg9 7/20

00:18:53

passed #315100542
gitlab-org
rspec unit pg9 8/20

00:17:55

passed #315100543
gitlab-org
rspec unit pg9 9/20

00:18:48

passed #315100571
gitlab-org
rspec unit pg9-foss 1/20

00:17:11

passed #315100582
gitlab-org
rspec unit pg9-foss 10/20

00:15:51

passed #315100583
gitlab-org
rspec unit pg9-foss 11/20

00:15:36

passed #315100584
gitlab-org
rspec unit pg9-foss 12/20

00:16:21

passed #315100585
gitlab-org
rspec unit pg9-foss 13/20

00:14:57

passed #315100586
gitlab-org
rspec unit pg9-foss 14/20

00:16:14

passed #315100587
gitlab-org
rspec unit pg9-foss 15/20

00:16:07

passed #315100588
gitlab-org
rspec unit pg9-foss 16/20

00:14:56

passed #315100589
gitlab-org
rspec unit pg9-foss 17/20

00:14:40

passed #315100590
gitlab-org
rspec unit pg9-foss 18/20

00:16:49

passed #315100591
gitlab-org
rspec unit pg9-foss 19/20

00:16:33

passed #315100572
gitlab-org
rspec unit pg9-foss 2/20

00:15:10

passed #315100592
gitlab-org
rspec unit pg9-foss 20/20

00:16:15

passed #315100573
gitlab-org
rspec unit pg9-foss 3/20

00:12:15

passed #315100574
gitlab-org
rspec unit pg9-foss 4/20

00:14:50

passed #315100575
gitlab-org
rspec unit pg9-foss 5/20

00:15:09

passed #315100578
gitlab-org
rspec unit pg9-foss 6/20

00:16:47

passed #315100579
gitlab-org
rspec unit pg9-foss 7/20

00:15:04

passed #315100580
gitlab-org
rspec unit pg9-foss 8/20

00:15:10

passed #315100581
gitlab-org
rspec unit pg9-foss 9/20

00:16:08

passed #315100674
gitlab-org
rspec-ee integration pg10 geo

00:07:11

passed #315100658
gitlab-org
rspec-ee integration pg9 1/3

00:15:31

passed #315100659
gitlab-org
rspec-ee integration pg9 2/3

00:15:20

passed #315100661
gitlab-org
rspec-ee integration pg9 3/3

00:14:30

passed #315100670
gitlab-org
rspec-ee integration pg9 geo

00:06:46

passed #315100675
gitlab-org
rspec-ee system pg10 geo

00:07:29

passed #315100663
gitlab-org
rspec-ee system pg9 1/5

00:15:15

passed #315100664
gitlab-org
rspec-ee system pg9 2/5

00:16:37

passed #315100665
gitlab-org
rspec-ee system pg9 3/5

00:17:43

passed #315100666
gitlab-org
rspec-ee system pg9 4/5

00:17:09

passed #315100667
gitlab-org
rspec-ee system pg9 5/5

00:18:01

passed #315100671
gitlab-org
rspec-ee system pg9 geo

00:06:35

passed #315100672
gitlab-org
rspec-ee unit pg10 geo 1/2

00:16:19

passed #315100673
gitlab-org
rspec-ee unit pg10 geo 2/2

00:14:16

passed #315100642
gitlab-org
rspec-ee unit pg9 1/7

00:16:16

passed #315100644
gitlab-org
rspec-ee unit pg9 2/7

00:15:41

passed #315100651
gitlab-org
rspec-ee unit pg9 3/7

00:19:07

passed #315100653
gitlab-org
rspec-ee unit pg9 4/7

00:17:38

passed #315100655
gitlab-org
rspec-ee unit pg9 5/7

00:15:34

passed #315100656
gitlab-org
rspec-ee unit pg9 6/7

00:16:24

passed #315100657
gitlab-org
rspec-ee unit pg9 7/7

00:15:33

passed #315100668
gitlab-org
rspec-ee unit pg9 geo 1/2

00:12:09

passed #315100669
gitlab-org
rspec-ee unit pg9 geo 2/2

00:16:05

passed #315100532
allowed to fail
sast

00:10:22

passed #315100677
gitlab-org
static-analysis

00:19:20

passed #315100527
gitlab-org
webpack-dev-server

00:05:04

 
  Review Prepare
passed #315100688
review-build-cng

00:32:54

 
  Review
failed #315100689
gitlab-org allowed to fail
review-deploy

00:01:06

manual #315100697
gitlab-org allowed to fail manual
review-stop
 
  Qa
passed #315100701
allowed to fail
dast

00:03:06

manual #315100700
allowed to fail manual
package-and-qa-manual
passed #315100711
docker gitlab-org allowed to fail
review-performance

00:02:54

manual #315100703
docker gitlab-org allowed to fail manual
review-qa-all 1/5
manual #315100706
docker gitlab-org allowed to fail manual
review-qa-all 2/5
manual #315100708
docker gitlab-org allowed to fail manual
review-qa-all 3/5
manual #315100709
docker gitlab-org allowed to fail manual
review-qa-all 4/5
manual #315100710
docker gitlab-org allowed to fail manual
review-qa-all 5/5
failed #315100702
docker gitlab-org allowed to fail
review-qa-smoke

00:05:52

 
  Post Test
passed #315100712
gitlab-org
coverage

00:05:12

97.2%
failed #315100715
gitlab-org allowed to fail
flaky-examples-check

00:02:45

manual #315100713
gitlab-org allowed to fail manual
parallel-spec-reports
 
Name Stage Failure
failed
flaky-examples-check Post Test
    "first_flaky_at": "2019-10-08 17:35:28 +0000",
"last_flaky_at": "2019-10-08 17:35:28 +0000",
"last_flaky_job": "https://gitlab.com/gitlab-org/gitlab/-/jobs/315100622"
}
}
Running after script...
$ date
Tue Oct 8 18:28:18 UTC 2019
ERROR: Job failed: exit code 1
failed
review-qa-smoke Qa
  /home/gitlab/qa/qa/scenario/bootable.rb:28:in `launch!'
bin/qa:7:in `<top (required)>'
Running after script...
$ date
Tue Oct 8 18:25:23 UTC 2019
Uploading artifacts...
./qa/gitlab-qa-run-*: found 2 matching files
Uploading artifacts to coordinator... ok
id=315100702 responseStatus=201 Created token=jPrqUNpQ
ERROR: Job failed: exit code 1
failed
review-deploy Review
Unsuccessful Jobs for release review-13345-cona-wx6glk
No resources found.
Running after script...
$ date
Tue Oct 8 18:19:35 UTC 2019
Uploading artifacts...
review_app_url.txt: found 1 matching files
Uploading artifacts to coordinator... ok
id=315100689 responseStatus=201 Created token=Mru84CPP
ERROR: Job failed: exit code 1