Address review comments

Addressed the review comments from the initial review
125 jobs for ee-je-add-group-deployments-page-fe in 84 minutes and 25 seconds (queued for 11 seconds)
Status Job ID Name Coverage
  Prepare
passed #278551809
gitlab-org
compile-assets pull-cache

00:08:02

passed #278551811
gitlab-org
retrieve-tests-metadata

00:01:05

passed #278551810
gitlab-org
setup-test-env

00:07:09

 
  Test
passed #278551997
docker gitlab-org
build-qa-image

00:05:45

passed #278551843
allowed to fail
code_quality

00:10:31

passed #278551999
gitlab-org
danger-review

00:02:03

passed #278551968
gitlab-org
db:check-schema-pg

00:03:43

passed #278551967
gitlab-org
db:migrate:reset-pg

00:03:08

passed #278551970
gitlab-org
db:rollback-pg

00:03:41

passed #278551996
gitlab-org
db:rollback-pg-geo

00:03:39

passed #278551847
allowed to fail
dependency_scanning

00:11:02

passed #278551812
gitlab-org
docs lint

00:02:42

passed #278551966
gitlab-org
downtime_check

00:02:11

passed #278552002
gitlab-org
ee-files-location-check

00:03:24

passed #278552003
gitlab-org
ee-specific-lines-check

00:03:40

passed #278551813
gitlab-org docker
gitlab:assets:compile pull-cache

00:19:57

passed #278551971
gitlab-org
gitlab:setup-pg

00:03:12

passed #278552001
gitlab-org
gitlab_git_test

00:00:24

passed #278551815
gitlab-org
jest

00:19:07

passed #278551814
gitlab-org
karma

00:15:51

68.54%
passed #278552004
gitlab-org
lint-ci-gitlab

00:01:30

passed #278551836
gitlab-org
memory-on-boot

00:05:32

passed #278551829
gitlab-org
memory-static

00:03:51

passed #278551969
gitlab-org
migration:path-pg

00:08:33

passed #278551995
gitlab-org
migration:upgrade-pg-ce-to-ee

00:07:01

passed #278551821
gitlab-org
qa-frontend-node:10

00:16:53

passed #278551820
gitlab-org
qa-frontend-node:8

00:19:49

passed #278551823
gitlab-org allowed to fail
qa-frontend-node:latest

00:17:15

passed #278551817
gitlab-org
qa:internal

00:05:22

passed #278551818
gitlab-org
qa:selectors

00:04:15

passed #278551998
allowed to fail manual
review-build-cng

00:30:33

passed #278551988
gitlab-org
rspec geo pg ee 1/3

00:09:40

passed #278551990
gitlab-org
rspec geo pg ee 2/3

00:07:40

passed #278551991
gitlab-org
rspec geo pg ee 3/3

00:11:23

passed #278551992
gitlab-org
rspec geo pg-10 ee 1/3

00:10:50

passed #278551993
gitlab-org
rspec geo pg-10 ee 2/3

00:07:50

passed #278551994
gitlab-org
rspec geo pg-10 ee 3/3

00:11:54

passed #278551921
gitlab-org
rspec integration pg 1/6

00:19:14

passed #278551922
gitlab-org
rspec integration pg 2/6

00:22:51

passed #278551924
gitlab-org
rspec integration pg 3/6

00:22:11

passed #278551926
gitlab-org
rspec integration pg 4/6

00:22:24

passed #278551929
gitlab-org
rspec integration pg 5/6

00:21:24

passed #278551933
gitlab-org
rspec integration pg 6/6

00:21:20

passed #278551979
gitlab-org
rspec integration pg ee 1/3

00:15:25

passed #278551980
gitlab-org
rspec integration pg ee 2/3

00:13:39

passed #278551981
gitlab-org
rspec integration pg ee 3/3

00:14:39

passed #278551935
gitlab-org
rspec system pg 1/24

00:16:46

passed #278551944
gitlab-org
rspec system pg 10/24

00:17:09

passed #278551946
gitlab-org
rspec system pg 11/24

00:15:27

passed #278551947
gitlab-org
rspec system pg 12/24

00:14:18

passed #278551948
gitlab-org
rspec system pg 13/24

00:15:07

passed #278551952
gitlab-org
rspec system pg 14/24

00:13:44

passed #278551954
gitlab-org
rspec system pg 15/24

00:15:29

passed #278551955
gitlab-org
rspec system pg 16/24

00:16:10

passed #278551956
gitlab-org
rspec system pg 17/24

00:16:57

passed #278551957
gitlab-org
rspec system pg 18/24

00:16:08

passed #278551958
gitlab-org
rspec system pg 19/24

00:13:31

passed #278551936
gitlab-org
rspec system pg 2/24

00:13:56

passed #278551959
gitlab-org
rspec system pg 20/24

00:15:23

passed #278551960
gitlab-org
rspec system pg 21/24

00:13:12

passed #278551961
gitlab-org
rspec system pg 22/24

00:12:09

passed #278551962
gitlab-org
rspec system pg 23/24

00:15:13

passed #278551963
gitlab-org
rspec system pg 24/24

00:15:58

passed #278551937
gitlab-org
rspec system pg 3/24

00:12:27

passed #278551938
gitlab-org
rspec system pg 4/24

00:14:37

passed #278551939
gitlab-org
rspec system pg 5/24

00:14:17

passed #278551940
gitlab-org
rspec system pg 6/24

00:13:52

passed #278551941
gitlab-org
rspec system pg 7/24

00:12:15

passed #278551942
gitlab-org
rspec system pg 8/24

00:15:58

passed #278551943
gitlab-org
rspec system pg 9/24

00:13:12

passed #278551982
gitlab-org
rspec system pg ee 1/5

00:14:19

passed #278551983
gitlab-org
rspec system pg ee 2/5

00:16:31

passed #278551985
gitlab-org
rspec system pg ee 3/5

00:15:19

passed #278551986
gitlab-org
rspec system pg ee 4/5

00:18:51

passed #278551987
gitlab-org
rspec system pg ee 5/5

00:16:41

passed #278561090
gitlab-org
rspec unit pg 1/20

00:18:17

passed #278551894
gitlab-org
rspec unit pg 10/20

00:20:14

passed #278551896
gitlab-org
rspec unit pg 11/20

00:16:03

passed #278551898
gitlab-org
rspec unit pg 12/20

00:16:59

passed #278551901
gitlab-org
rspec unit pg 13/20

00:19:24

passed #278551905
gitlab-org
rspec unit pg 14/20

00:18:15

passed #278551909
gitlab-org
rspec unit pg 15/20

00:17:21

passed #278551910
gitlab-org
rspec unit pg 16/20

00:17:17

passed #278551912
gitlab-org
rspec unit pg 17/20

00:19:07

passed #278551914
gitlab-org
rspec unit pg 18/20

00:19:08

passed #278551917
gitlab-org
rspec unit pg 19/20

00:16:48

passed #278551854
gitlab-org
rspec unit pg 2/20

00:16:35

passed #278551920
gitlab-org
rspec unit pg 20/20

00:20:15

passed #278551857
gitlab-org
rspec unit pg 3/20

00:15:52

passed #278551860
gitlab-org
rspec unit pg 4/20

00:15:59

passed #278551871
gitlab-org
rspec unit pg 5/20

00:15:56

passed #278551884
gitlab-org
rspec unit pg 6/20

00:17:13

passed #278551889
gitlab-org
rspec unit pg 7/20

00:17:13

passed #278551892
gitlab-org
rspec unit pg 8/20

00:17:20

passed #278551893
gitlab-org
rspec unit pg 9/20

00:19:18

passed #278551972
gitlab-org
rspec unit pg ee 1/7

00:12:22

passed #278551973
gitlab-org
rspec unit pg ee 2/7

00:13:49

passed #278551974
gitlab-org
rspec unit pg ee 3/7

00:13:15

passed #278551975
gitlab-org
rspec unit pg ee 4/7

00:13:02

passed #278551976
gitlab-org
rspec unit pg ee 5/7

00:16:04

passed #278551977
gitlab-org
rspec unit pg ee 6/7

00:14:35

passed #278551978
gitlab-org
rspec unit pg ee 7/7

00:15:15

passed #278551964
gitlab-org
rspec-fast-spec-helper

00:05:29

passed #278551845
allowed to fail
sast

00:08:12

passed #278551965
gitlab-org
static-analysis

00:35:51

failed #278551850
gitlab-org
rspec unit pg 1/20

00:04:58

 
  Review
manual #278552014
allowed to fail manual
package-and-qa
passed #278552015
gitlab-org allowed to fail
review-deploy

00:14:21

manual #278552011
gitlab-org allowed to fail manual
review-docs-cleanup
manual #278552009
gitlab-org allowed to fail manual
review-docs-deploy-manual
manual #278552020
gitlab-org allowed to fail manual
review-stop
 
  Qa
passed #278552034
docker gitlab-org allowed to fail
review-performance

00:03:15

manual #278552028
docker gitlab-org allowed to fail manual
review-qa-all 1/5
manual #278552030
docker gitlab-org allowed to fail manual
review-qa-all 2/5
manual #278552031
docker gitlab-org allowed to fail manual
review-qa-all 3/5
manual #278552032
docker gitlab-org allowed to fail manual
review-qa-all 4/5
manual #278552033
docker gitlab-org allowed to fail manual
review-qa-all 5/5
failed #278621934
docker gitlab-org allowed to fail
review-qa-smoke

00:04:31

failed #278618589
gitlab-org docker allowed to fail
review-qa-smoke

00:04:09

failed #278552025
docker gitlab-org allowed to fail
review-qa-smoke

00:04:17

 
  Post Test
passed #278552037
gitlab-org
coverage

00:04:05

96.78%
passed #278552039
gitlab-org allowed to fail
flaky-examples-check

00:02:32

passed #278552036
gitlab-org
jsdoc

00:01:50

passed #278552035
gitlab-org
lint:javascript:report

00:00:44

manual #278552038
gitlab-org allowed to fail manual
parallel-spec-reports
 
Name Stage Failure
failed
review-qa-smoke Qa
Randomized with seed 12755

Running after script...
$ date
Fri Aug 23 09:23:14 UTC 2019
Uploading artifacts...
./qa/gitlab-qa-run-*: found 38 matching files
Uploading artifacts to coordinator... ok
id=278621934 responseStatus=201 Created token=BcQ2sKq3
ERROR: Job failed: exit code 1