Fix linting errors

* Remove unneeded use of `private`
* Use `table` instead of FactoryBot methods in migration spec
124 jobs for migrate-fingerprints-to-backend in 57 minutes and 54 seconds (queued for 5 seconds)
Status Job ID Name Coverage
  Prepare
passed #277522478
gitlab-org
compile-assets pull-cache

00:09:49

passed #277522480
gitlab-org
retrieve-tests-metadata

00:00:29

passed #277522479
gitlab-org
setup-test-env

00:08:16

 
  Test
passed #277522584
docker gitlab-org
build-qa-image

00:05:51

passed #277522492
allowed to fail
code_quality

00:10:59

passed #277522586
gitlab-org
danger-review

00:02:18

passed #277522556
gitlab-org
db:check-schema-pg

00:02:43

passed #277522555
gitlab-org
db:migrate:reset-pg

00:03:05

passed #277522558
gitlab-org
db:rollback-pg

00:05:22

passed #277522582
gitlab-org
db:rollback-pg-geo

00:02:57

passed #277522494
allowed to fail
dependency_scanning

00:10:36

passed #277522481
gitlab-org
docs lint

00:02:56

passed #277522554
gitlab-org
downtime_check

00:02:23

failed #277522588
gitlab-org
ee-files-location-check

00:03:33

failed #277522589
gitlab-org
ee-specific-lines-check

00:03:19

passed #277522482
gitlab-org docker
gitlab:assets:compile pull-cache

00:20:32

passed #277522559
gitlab-org
gitlab:setup-pg

00:03:37

passed #277522587
gitlab-org
gitlab_git_test

00:00:36

passed #277522484
gitlab-org
jest

00:18:32

passed #277522483
gitlab-org
karma

00:16:11

68.72%
passed #277522590
gitlab-org
lint-ci-gitlab

00:00:36

passed #277522491
gitlab-org
memory-on-boot

00:05:30

passed #277522490
gitlab-org
memory-static

00:03:24

passed #277522557
gitlab-org
migration:path-pg

00:10:06

passed #277522581
gitlab-org
migration:upgrade-pg-ce-to-ee

00:06:05

passed #277522488
gitlab-org
qa-frontend-node:10

00:16:32

passed #277525202
gitlab-org
qa-frontend-node:8

00:21:22

passed #277522489
gitlab-org allowed to fail
qa-frontend-node:latest

00:15:37

passed #277522485
gitlab-org
qa:internal

00:03:11

passed #277522486
gitlab-org
qa:selectors

00:03:15

passed #277522585
allowed to fail manual
review-build-cng

00:27:55

passed #277522575
gitlab-org
rspec geo pg ee 1/3

00:12:04

passed #277522576
gitlab-org
rspec geo pg ee 2/3

00:07:59

passed #277522577
gitlab-org
rspec geo pg ee 3/3

00:11:17

passed #277522578
gitlab-org
rspec geo pg-10 ee 1/3

00:09:35

passed #277522579
gitlab-org
rspec geo pg-10 ee 2/3

00:08:57

passed #277522580
gitlab-org
rspec geo pg-10 ee 3/3

00:09:35

passed #277522516
gitlab-org
rspec integration pg 1/6

00:15:07

passed #277522517
gitlab-org
rspec integration pg 2/6

00:22:05

passed #277522518
gitlab-org
rspec integration pg 3/6

00:19:49

passed #277522519
gitlab-org
rspec integration pg 4/6

00:24:06

passed #277522520
gitlab-org
rspec integration pg 5/6

00:18:47

passed #277522521
gitlab-org
rspec integration pg 6/6

00:23:49

passed #277522567
gitlab-org
rspec integration pg ee 1/3

00:16:17

passed #277522568
gitlab-org
rspec integration pg ee 2/3

00:16:39

passed #277522569
gitlab-org
rspec integration pg ee 3/3

00:14:02

passed #277526105
gitlab-org
rspec system pg 1/24

00:12:44

passed #277522535
gitlab-org
rspec system pg 10/24

00:14:35

passed #277522536
gitlab-org
rspec system pg 11/24

00:13:23

passed #277522539
gitlab-org
rspec system pg 12/24

00:12:56

passed #277522540
gitlab-org
rspec system pg 13/24

00:13:55

passed #277522541
gitlab-org
rspec system pg 14/24

00:14:26

passed #277522542
gitlab-org
rspec system pg 15/24

00:13:47

passed #277522543
gitlab-org
rspec system pg 16/24

00:14:26

passed #277522544
gitlab-org
rspec system pg 17/24

00:15:18

passed #277522545
gitlab-org
rspec system pg 18/24

00:13:09

passed #277522546
gitlab-org
rspec system pg 19/24

00:16:19

passed #277522523
gitlab-org
rspec system pg 2/24

00:13:27

passed #277522547
gitlab-org
rspec system pg 20/24

00:15:05

passed #277522548
gitlab-org
rspec system pg 21/24

00:15:41

passed #277522549
gitlab-org
rspec system pg 22/24

00:14:18

passed #277522550
gitlab-org
rspec system pg 23/24

00:15:17

passed #277522551
gitlab-org
rspec system pg 24/24

00:14:35

passed #277522524
gitlab-org
rspec system pg 3/24

00:12:38

passed #277522525
gitlab-org
rspec system pg 4/24

00:16:24

passed #277522526
gitlab-org
rspec system pg 5/24

00:14:19

passed #277522527
gitlab-org
rspec system pg 6/24

00:16:04

passed #277522529
gitlab-org
rspec system pg 7/24

00:14:30

passed #277522531
gitlab-org
rspec system pg 8/24

00:14:36

passed #277522533
gitlab-org
rspec system pg 9/24

00:14:40

passed #277522570
gitlab-org
rspec system pg ee 1/5

00:13:49

passed #277522571
gitlab-org
rspec system pg ee 2/5

00:15:16

passed #277522572
gitlab-org
rspec system pg ee 3/5

00:14:30

passed #277522573
gitlab-org
rspec system pg ee 4/5

00:16:34

passed #277522574
gitlab-org
rspec system pg ee 5/5

00:13:58

passed #277522495
gitlab-org
rspec unit pg 1/20

00:19:41

passed #277522504
gitlab-org
rspec unit pg 10/20

00:19:48

passed #277522505
gitlab-org
rspec unit pg 11/20

00:22:47

passed #277522506
gitlab-org
rspec unit pg 12/20

00:17:58

passed #277522507
gitlab-org
rspec unit pg 13/20

00:21:00

passed #277522508
gitlab-org
rspec unit pg 14/20

00:18:03

passed #277522509
gitlab-org
rspec unit pg 15/20

00:20:15

passed #277522510
gitlab-org
rspec unit pg 16/20

00:16:13

passed #277522511
gitlab-org
rspec unit pg 17/20

00:16:45

passed #277522512
gitlab-org
rspec unit pg 18/20

00:16:53

passed #277522513
gitlab-org
rspec unit pg 19/20

00:21:58

passed #277522496
gitlab-org
rspec unit pg 2/20

00:11:29

passed #277522514
gitlab-org
rspec unit pg 20/20

00:16:03

passed #277522497
gitlab-org
rspec unit pg 3/20

00:16:30

passed #277522498
gitlab-org
rspec unit pg 4/20

00:15:04

passed #277522499
gitlab-org
rspec unit pg 5/20

00:16:20

passed #277522500
gitlab-org
rspec unit pg 6/20

00:16:25

passed #277522501
gitlab-org
rspec unit pg 7/20

00:17:04

passed #277522502
gitlab-org
rspec unit pg 8/20

00:16:37

passed #277522503
gitlab-org
rspec unit pg 9/20

00:20:16

passed #277522560
gitlab-org
rspec unit pg ee 1/7

00:13:30

passed #277522561
gitlab-org
rspec unit pg ee 2/7

00:11:34

passed #277522562
gitlab-org
rspec unit pg ee 3/7

00:13:49

passed #277522563
gitlab-org
rspec unit pg ee 4/7

00:14:16

passed #277522564
gitlab-org
rspec unit pg ee 5/7

00:12:50

passed #277522565
gitlab-org
rspec unit pg ee 6/7

00:15:59

passed #277522566
gitlab-org
rspec unit pg ee 7/7

00:14:47

passed #277522552
gitlab-org
rspec-fast-spec-helper

00:04:49

passed #277522493
allowed to fail
sast

00:09:42

passed #277522553
gitlab-org
static-analysis

00:17:37

failed #277522487
gitlab-org
qa-frontend-node:8

00:00:36

failed #277522522
gitlab-org
rspec system pg 1/24

00:04:54

 
  Review
skipped #277522594
allowed to fail manual
package-and-qa
skipped #277522595
gitlab-org allowed to fail
review-deploy
skipped #277522593
gitlab-org allowed to fail manual
review-docs-cleanup
skipped #277522591
gitlab-org allowed to fail manual
review-docs-deploy-manual
skipped #277522597
gitlab-org allowed to fail manual
review-stop
 
  Qa
skipped #277522605
docker gitlab-org allowed to fail
review-performance
skipped #277522599
docker gitlab-org allowed to fail manual
review-qa-all 1/5
skipped #277522600
docker gitlab-org allowed to fail manual
review-qa-all 2/5
skipped #277522601
docker gitlab-org allowed to fail manual
review-qa-all 3/5
skipped #277522602
docker gitlab-org allowed to fail manual
review-qa-all 4/5
skipped #277522604
docker gitlab-org allowed to fail manual
review-qa-all 5/5
skipped #277522598
docker gitlab-org allowed to fail
review-qa-smoke
 
  Post Test
skipped #277522608
gitlab-org
coverage
skipped #277522610
gitlab-org allowed to fail
flaky-examples-check
skipped #277522607
gitlab-org
jsdoc
skipped #277522606
gitlab-org
lint:javascript:report
skipped #277522609
gitlab-org allowed to fail manual
parallel-spec-reports
 
Name Stage Failure
failed
ee-files-location-check Test
=> Running `git remote remove target-ce`
fatal: No such remote: 'target-ce'

ℹ️ For more information on the why and how of this job, see https://docs.gitlab.com/ee/development/ee_features.html#detection-of-ee-only-files

Running after script...
$ date
Thu Aug 22 03:55:22 UTC 2019
ERROR: Job failed: exit code 1
failed
ee-specific-lines-check Test
=> Running `git remote remove target-ce`
fatal: No such remote: 'target-ce'

ℹ️ For more information on why, see https://gitlab.com/gitlab-org/gitlab-ee/issues/2952

Running after script...
$ date
Thu Aug 22 03:55:09 UTC 2019
ERROR: Job failed: exit code 1