Update specs to use #update! rather than #update

As #update! will fail with an error if the update is not successful.
175 jobs for 7532-allow-self-approvals-even-when-not-in-approvers-list in 88 minutes and 37 seconds (queued for 7 seconds)
Status Job ID Name Coverage
  Build
manual #190306805
gitlab-org allowed to fail manual
review-docs-deploy-manual
 
  Prepare
passed #190306813
gitlab-org docker
build-qa-image

00:05:11

passed #190306810
gitlab-org
compile-assets

00:12:13

passed #190306809
gitlab-org
retrieve-tests-metadata

00:00:32

passed #190306811
gitlab-org
setup-test-env

00:07:55

 
  Test
passed #190306814
allowed to fail
code_quality

00:11:53

passed #190306820
danger-review

00:03:05

passed #190306957
gitlab-org
db:check-schema-pg

00:03:54

passed #190306956
gitlab-org
db:migrate:reset-mysql

00:05:48

passed #190306955
gitlab-org
db:migrate:reset-pg

00:06:38

passed #190306964
gitlab-org
db:rollback-mysql

00:05:38

passed #190306963
gitlab-org
db:rollback-pg

00:04:37

passed #190306965
gitlab-org
db:rollback-pg-geo

00:04:09

passed #190306972
allowed to fail
dependency_scanning

00:08:29

passed #190306952
gitlab-org
docs lint

00:02:45

passed #190306953
gitlab-org
downtime_check

00:05:38

passed #190306817
gitlab-org
ee-files-location-check

00:04:44

passed #190306818
gitlab-org
ee-specific-lines-check

00:04:49

passed #190306968
docker gitlab-org
gitlab:assets:compile

00:26:48

passed #190306967
gitlab-org
gitlab:setup-mysql

00:09:25

passed #190306966
gitlab-org
gitlab:setup-pg

00:09:44

passed #190306978
gitlab-org
gitlab_git_test

00:00:35

passed #190306970
gitlab-org
jest

00:15:08

passed #190306969
gitlab-org
karma

00:20:44

72.19%
passed #190306960
gitlab-org
migration:path-mysql

00:18:48

passed #190306958
gitlab-org
migration:path-pg

00:18:27

passed #190306962
gitlab-org
migration:upgrade-mysql-ce-to-ee

00:11:14

passed #190306961
gitlab-org
migration:upgrade-pg-ce-to-ee

00:10:13

manual #190306815
allowed to fail manual
package-and-qa
passed #190306976
gitlab-org
qa-frontend-node:10

00:13:32

passed #190306975
gitlab-org
qa-frontend-node:8

00:18:47

passed #190306977
gitlab-org allowed to fail
qa-frontend-node:latest

00:14:48

passed #190306973
gitlab-org
qa:internal

00:04:33

passed #190306974
gitlab-org
qa:selectors

00:04:32

passed #190306979
review-build-cng

00:47:54

passed #190306980
gitlab-org allowed to fail
review-deploy

00:51:47

passed #190306983
gitlab-org docker allowed to fail
review-performance

00:54:22

manual #190306982
gitlab-org docker allowed to fail manual
review-qa-all
passed #190306981
gitlab-org docker allowed to fail
review-qa-smoke

00:55:58

manual #190306984
gitlab-org allowed to fail manual
review-stop
passed #190306873
gitlab-org
rspec-mysql 1/50

00:24:34

passed #190306882
gitlab-org
rspec-mysql 10/50

00:24:36

passed #190306883
gitlab-org
rspec-mysql 11/50

00:25:16

passed #190306884
gitlab-org
rspec-mysql 12/50

00:20:34

passed #190306885
gitlab-org
rspec-mysql 13/50

00:41:04

passed #190306886
gitlab-org
rspec-mysql 14/50

00:27:03

passed #190306887
gitlab-org
rspec-mysql 15/50

00:30:03

passed #190306888
gitlab-org
rspec-mysql 16/50

01:00:23

passed #190306889
gitlab-org
rspec-mysql 17/50

00:21:57

passed #190306890
gitlab-org
rspec-mysql 18/50

00:28:43

passed #190306892
gitlab-org
rspec-mysql 19/50

00:24:22

passed #190306874
gitlab-org
rspec-mysql 2/50

00:26:23

passed #190306893
gitlab-org
rspec-mysql 20/50

00:24:42

passed #190306894
gitlab-org
rspec-mysql 21/50

00:24:54

passed #190306895
gitlab-org
rspec-mysql 22/50

00:22:51

passed #190306896
gitlab-org
rspec-mysql 23/50

00:25:27

passed #190306897
gitlab-org
rspec-mysql 24/50

00:27:41

passed #190306898
gitlab-org
rspec-mysql 25/50

00:28:03

passed #190306899
gitlab-org
rspec-mysql 26/50

00:27:32

passed #190306900
gitlab-org
rspec-mysql 27/50

00:24:54

passed #190306901
gitlab-org
rspec-mysql 28/50

00:33:37

passed #190306902
gitlab-org
rspec-mysql 29/50

00:26:11

passed #190306875
gitlab-org
rspec-mysql 3/50

00:21:15

passed #190306903
gitlab-org
rspec-mysql 30/50

00:24:34

passed #190306904
gitlab-org
rspec-mysql 31/50

00:26:57

passed #190306905
gitlab-org
rspec-mysql 32/50

00:21:14

passed #190306906
gitlab-org
rspec-mysql 33/50

00:37:24

passed #190306907
gitlab-org
rspec-mysql 34/50

00:27:12

failed #190318727
gitlab-org
rspec-mysql 35/50

00:38:02

passed #190306909
gitlab-org
rspec-mysql 36/50

00:25:40

passed #190306910
gitlab-org
rspec-mysql 37/50

00:46:49

passed #190306911
gitlab-org
rspec-mysql 38/50

00:24:45

passed #190306912
gitlab-org
rspec-mysql 39/50

00:23:04

passed #190306876
gitlab-org
rspec-mysql 4/50

00:42:16

passed #190306913
gitlab-org
rspec-mysql 40/50

00:31:24

passed #190306914
gitlab-org
rspec-mysql 41/50

00:23:29

passed #190306915
gitlab-org
rspec-mysql 42/50

00:23:10

passed #190306916
gitlab-org
rspec-mysql 43/50

00:25:24

passed #190306917
gitlab-org
rspec-mysql 44/50

00:26:14

passed #190306918
gitlab-org
rspec-mysql 45/50

00:24:13

passed #190306919
gitlab-org
rspec-mysql 46/50

00:30:28

passed #190306920
gitlab-org
rspec-mysql 47/50

00:31:18

passed #190306921
gitlab-org
rspec-mysql 48/50

00:29:48

passed #190306922
gitlab-org
rspec-mysql 49/50

00:30:25

passed #190306877
gitlab-org
rspec-mysql 5/50

00:32:24

passed #190306923
gitlab-org
rspec-mysql 50/50

00:33:01

passed #190306878
gitlab-org
rspec-mysql 6/50

00:20:10

passed #190306879
gitlab-org
rspec-mysql 7/50

00:33:17

passed #190306880
gitlab-org
rspec-mysql 8/50

00:21:32

passed #190306881
gitlab-org
rspec-mysql 9/50

00:19:49

passed #190306936
gitlab-org
rspec-mysql-ee 1/10

00:23:53

passed #190306945
gitlab-org
rspec-mysql-ee 10/10

00:40:44

passed #190306937
gitlab-org
rspec-mysql-ee 2/10

00:20:31

passed #190306938
gitlab-org
rspec-mysql-ee 3/10

00:30:35

passed #190306939
gitlab-org
rspec-mysql-ee 4/10

00:32:09

passed #190306940
gitlab-org
rspec-mysql-ee 5/10

00:32:36

passed #190306941
gitlab-org
rspec-mysql-ee 6/10

00:26:32

passed #190306942
gitlab-org
rspec-mysql-ee 7/10

00:38:21

passed #190306943
gitlab-org
rspec-mysql-ee 8/10

00:33:21

passed #190306944
gitlab-org
rspec-mysql-ee 9/10

00:28:33

failed #190306925
gitlab-org allowed to fail
rspec-mysql-quarantine

00:28:16

passed #190306950
gitlab-org allowed to fail
rspec-mysql-quarantine-ee

00:08:22

passed #190306821
gitlab-org
rspec-pg 1/50

00:25:19

passed #190306832
gitlab-org
rspec-pg 10/50

00:21:16

passed #190306833
gitlab-org
rspec-pg 11/50

00:23:49

passed #190306834
gitlab-org
rspec-pg 12/50

00:21:08

passed #190306835
gitlab-org
rspec-pg 13/50

00:33:43

passed #190306836
gitlab-org
rspec-pg 14/50

00:29:29

passed #190306837
gitlab-org
rspec-pg 15/50

00:24:12

passed #190306838
gitlab-org
rspec-pg 16/50

00:38:14

passed #190306839
gitlab-org
rspec-pg 17/50

00:21:05

passed #190306840
gitlab-org
rspec-pg 18/50

00:29:41

passed #190306841
gitlab-org
rspec-pg 19/50

00:26:05

passed #190306824
gitlab-org
rspec-pg 2/50

00:26:38

passed #190306842
gitlab-org
rspec-pg 20/50

00:33:34

passed #190306843
gitlab-org
rspec-pg 21/50

00:26:08

passed #190306844
gitlab-org
rspec-pg 22/50

00:24:50

passed #190306845
gitlab-org
rspec-pg 23/50

00:24:48

passed #190306846
gitlab-org
rspec-pg 24/50

00:29:39

passed #190306847
gitlab-org
rspec-pg 25/50

00:37:07

passed #190306848
gitlab-org
rspec-pg 26/50

00:29:07

passed #190306849
gitlab-org
rspec-pg 27/50

00:23:53

passed #190306850
gitlab-org
rspec-pg 28/50

00:28:51

passed #190306851
gitlab-org
rspec-pg 29/50

00:25:36

passed #190306825
gitlab-org
rspec-pg 3/50

00:23:07

passed #190306852
gitlab-org
rspec-pg 30/50

00:26:43

passed #190306853
gitlab-org
rspec-pg 31/50

00:22:37

passed #190306854
gitlab-org
rspec-pg 32/50

00:26:10

passed #190306855
gitlab-org
rspec-pg 33/50

00:27:25

passed #190306856
gitlab-org
rspec-pg 34/50

00:34:14

failed #190316017
gitlab-org
rspec-pg 35/50

00:29:13

passed #190306858
gitlab-org
rspec-pg 36/50

00:28:38

passed #190306859
gitlab-org
rspec-pg 37/50

00:28:20

passed #190306860
gitlab-org
rspec-pg 38/50

00:23:53

passed #190306861
gitlab-org
rspec-pg 39/50

00:23:11

passed #190306826
gitlab-org
rspec-pg 4/50

00:29:25

passed #190306862
gitlab-org
rspec-pg 40/50

00:30:12

passed #190306863
gitlab-org
rspec-pg 41/50

00:23:31

passed #190306864
gitlab-org
rspec-pg 42/50

00:24:59

passed #190306865
gitlab-org
rspec-pg 43/50

00:27:52

passed #190306866
gitlab-org
rspec-pg 44/50

00:25:42

passed #190306867
gitlab-org
rspec-pg 45/50

00:23:09

passed #190306868
gitlab-org
rspec-pg 46/50

00:27:27

passed #190306869
gitlab-org
rspec-pg 47/50

00:25:46

passed #190306870
gitlab-org
rspec-pg 48/50

00:29:59

passed #190306871
gitlab-org
rspec-pg 49/50

00:35:21

passed #190306827
gitlab-org
rspec-pg 5/50

00:36:12

passed #190306872
gitlab-org
rspec-pg 50/50

00:27:02

passed #190306828
gitlab-org
rspec-pg 6/50

00:18:18

passed #190306829
gitlab-org
rspec-pg 7/50

00:38:02

passed #190306830
gitlab-org
rspec-pg 8/50

00:22:13

passed #190306831
gitlab-org
rspec-pg 9/50

00:21:57

passed #190306946
gitlab-org
rspec-pg geo

00:23:18

passed #190306948
gitlab-org
rspec-pg-10 geo

00:22:57

passed #190306926
gitlab-org
rspec-pg-ee 1/10

00:23:45

passed #190306935
gitlab-org
rspec-pg-ee 10/10

00:44:28

passed #190306927
gitlab-org
rspec-pg-ee 2/10

00:22:18

passed #190306928
gitlab-org
rspec-pg-ee 3/10

00:32:35

passed #190306929
gitlab-org
rspec-pg-ee 4/10

00:30:15

passed #190306930
gitlab-org
rspec-pg-ee 5/10

00:37:04

passed #190306931
gitlab-org
rspec-pg-ee 6/10

00:30:33

passed #190306932
gitlab-org
rspec-pg-ee 7/10

00:31:08

passed #190306933
gitlab-org
rspec-pg-ee 8/10

00:34:22

passed #190306934
gitlab-org
rspec-pg-ee 9/10

00:32:40

failed #190306924
gitlab-org allowed to fail
rspec-pg-quarantine

00:19:11

passed #190306949
gitlab-org allowed to fail
rspec-pg-quarantine-ee

00:05:24

passed #190306971
allowed to fail
sast

00:08:42

passed #190306951
gitlab-org
static-analysis

00:16:37

failed #190306908
gitlab-org
rspec-mysql 35/50

00:38:17

failed #190306857
gitlab-org
rspec-pg 35/50

00:32:16

 
  Post Test
skipped #190306986
gitlab-org
coverage
skipped #190306985
gitlab-org allowed to fail
flaky-examples-check
skipped #190306988
gitlab-org
jsdoc
skipped #190306987
gitlab-org
lint:javascript:report
 
  Post Cleanup
skipped #190306989
gitlab-org allowed to fail manual
review-docs-cleanup
 
Name Stage Failure
failed
rspec-pg 35/50 Test
knapsack/: found 5 matching files                  
rspec_flaky/: found 4 matching files

rspec_profiling/: found 1 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=190316017 responseStatus=201 Created token=FxxMYB_p
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=190316017 responseStatus=201 Created token=FxxMYB_p
ERROR: Job failed: exit code 1
failed
rspec-mysql 35/50 Test
knapsack/: found 5 matching files                  
rspec_flaky/: found 4 matching files

rspec_profiling/: found 1 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=190318727 responseStatus=201 Created token=kRHvkD4e
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=190318727 responseStatus=201 Created token=kRHvkD4e
ERROR: Job failed: exit code 1
failed
rspec-mysql-quarantine Test
knapsack/: found 4 matching files                  
rspec_flaky/: found 2 matching files

rspec_profiling/: found 1 matching files

tmp/capybara/: found 19 matching files

Uploading artifacts to coordinator... ok
id=190306925 responseStatus=201 Created token=pWff5Mfk
Uploading artifacts...
WARNING: junit_rspec.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit code 1
failed
rspec-pg-quarantine Test
knapsack/: found 4 matching files                  
rspec_flaky/: found 2 matching files

rspec_profiling/: found 1 matching files

tmp/capybara/: found 11 matching files

Uploading artifacts to coordinator... ok
id=190306924 responseStatus=201 Created token=GoZg9V58
Uploading artifacts...
WARNING: junit_rspec.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit code 1