Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 23,588
    • Issues 23,588
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 839
    • Merge Requests 839
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !9047

Closed
Opened Jan 07, 2019 by Shinya Maeda@dosuken1235 of 6 tasks completed5/6 tasks
  • Report abuse
Report abuse

Add a feature flag for Feature Flag index page TAB change

What does this MR do?

This MR adds a feature flag to https://gitlab.com/gitlab-org/gitlab-ee/issues/7731. So that we can slack off to merge https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8821 without worrying about the feature freezing day.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

  • [-] Changelog entry added, if necessary
  • [-] Documentation created/updated
  • Tests added for this feature/bug
  • [-] Tested in all supported browsers
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • Conforms to the database guides
  • [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
  • [-] EE specific content should be in the top level /ee folder
  • [-] For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
  • Security reports checked/validated by reviewer
Edited Jan 07, 2019 by Shinya Maeda

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "add-counter-to-feature-flag-entity" "origin/add-counter-to-feature-flag-entity"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "add-counter-to-feature-flag-entity"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 3
  • Commits 1
  • Pipelines 1
  • Changes 1
Assignee
Assign to
11.7
Milestone
11.7
Assign milestone
Time tracking
12
Labels
Category:Feature Flags Deliverable Enterprise Edition GitLab Premium Release [DEPRECATED] UX ready [DEPRECATED] backstage devops::release feature management frontend missed-deliverable missed:11.6
Assign labels
  • View project labels
Reference: gitlab-org/gitlab!9047