Group SAML status badges on members page
What
Adds SAML SSO status badges to the group members page
Avoids N+1 queries using ActiveRecord::Associations::Preloader
in MembersPresentation
via a new MembersPreloader
. Because group.saml_provider
also caused an N+1 problem we load both with group_saml_identities: :saml_provider
and compare on identity.saml_provider.group_id == group.id
instead.
CE MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22587
Why
Allows group admins to determine if an account has been linked
Screenshots
Group Members | Project Members |
---|---|
Admin Group Members | Admin Project Members |
---|---|
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer
-
-
Internationalization required/considered -
End-to-end tests pass ( package-qa
manual pipeline job)
What are the relevant issue numbers?
Edited by James Edwards-Jones