Skip to content

Improve performance of repository size check

What does this MR do?

It gets the size of the changes of a new push by using the commands git diff and git cat-file instead of iterating over each delta. This is the same strategy that we use for the Max File Size push rule.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Pushing large changes for large repos were causing time out errors.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes #5566 (closed)

Edited by Rubén Dávila

Merge request reports