Skip to content

Port Group member contribution analytics table to Vue

Kushal Pandya requested to merge 4949-replace-tablesorter-with-vue into master

What does this MR do?

This MR replaces use of vendor/assets/javascripts/jquery.tablesorter.js, and implements Group contribution analytics sortable table in Vue.

Things pending in this MR

Why was this MR needed?

As mentioned in older version of this MR !4941 (closed), jQuery tablesorter used in GitLab is no longer maintained, and has been forked into more capable tablesorter, but since our table doesn't use all the sorting features that the plugin provides, it is better to remove the plugin dependency and use Vue. Not to mention that this MR would reduce our bundle size by 20 KB.

Screenshots

Page Breadcrumb

image

Contribution Stats

Contribution_Graph

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • [ ] Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • [ ] Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • [ ] End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes #4949 (closed)

Edited by Kushal Pandya

Merge request reports