Skip to content

Refactor SpamService

charlie ablett requested to merge cablett-spam-tidy-spamservice-execute into master

What does this MR do?

Part of a general tidying of spam logic.

  • Renames SpamService to SpamCheckService so it's obvious what it does.
  • Uses execute for consistency with other services
  • Extract shared_examples to its own file
  • Update tests

Related to #196157 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by charlie ablett

Merge request reports