review-performance (and other review jobs) should also use `rules`
What does this MR do?
Use rules
for the following jobs, otherwise it'll generate some invalid pipelines.
review-deploy
review-performance
review-stop-failed-deployment
review-stop
Follow up from !21945 (merged)
This fixes:
- Remove the invalid branch pipeline (could be found at !22231 (merged) and !22029 (merged))
- Fix the merge request pipeline for security repo (could be found at https://gitlab.com/gitlab-org/security/gitlab/merge_requests/38/pipelines)
Left over issue:
This will still create a lone branch pipeline with just build-qa-image
:
If we want to fix it, we probably need to have a list of branches we want to run it. It should be aligned with where we run QA or Review.
Follow up issue: #191266 (closed)
Edited by Lin Jen-Shin