Skip to content

review-performance (and other review jobs) should also use `rules`

Lin Jen-Shin requested to merge fix-remove-branch-pipeline into master

What does this MR do?

Use rules for the following jobs, otherwise it'll generate some invalid pipelines.

  • review-deploy
  • review-performance
  • review-stop-failed-deployment
  • review-stop

Follow up from !21945 (merged)

This fixes:

Left over issue:

This will still create a lone branch pipeline with just build-qa-image:

Screen_Shot_2019-12-24_at_13.43.09

If we want to fix it, we probably need to have a list of branches we want to run it. It should be aligned with where we run QA or Review.

Follow up issue: #191266 (closed)

Edited by Lin Jen-Shin

Merge request reports