Skip to content

Add dynamic deadlines to gitaly

What does this MR do?

This makes sure that the deadline we set on a gitaly call never exceeds the request deadline.

We also raise an exception if the request deadline has already been exceeded by the time we're trying to make a Gitaly call.

These deadlines don't apply when calling gitaly from Sidekiq.

We do this by storing the start time of the request in the request store on the thread (using the RequestStore).

The maximum time runtime for a request is currently set to 55 seconds.

This will make sure that we don't have to kill the unicorn if the request goes long.

Part of gitlab-com/gl-infra/scalability#71 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Bob Van Landuyt

Merge request reports