Preload group ancestor to avoid N+1
What does this MR do?
For getting number of epics in a group and all its subgroups, we have to first check which subgroups are visible to the user. This permission check is not very effective because multiple additional SQL queries are done.
Because two of these extra queries are done because we need to get root ancestor for each group, we can optimize it be presetting root ancestor for all groups before doing permission check.
Related to #33638 (closed)
Related to #37368 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team