Skip to content

Finalise vue packages list app

Nicolò Maria Mezzopera requested to merge 33905-connect-app-and-vuex into master

What does this MR do?

This MR aim to connect vuex and vue app generated in this MRs: !!19711 (merged) and !19613 (merged) respectively ( and !19957 (merged) for the groups side ) and provide the final functionality.

The full plan and course of action is described in !18860 (merged)

Why this MR does not close the issue

The original issue #33905 (closed) can be closed only when this issue: #35527 (closed) is solved and the vue functionality can 100% replace the haml functionality.

What is missing

Due to the lack of data in the current API:

  • created is empty ( and defaults to now )
  • project_path is empty as well ( to navigate to the details )
  • project name ( on the group ) is empty
  • Sorting, component is there but API does not support it yet

Screenshots

List:

localhost_3000_gitlab-instance-administrators-68dc2b83_gitlab-instance-administration_-_packages

Delete modal confirmation:

OLD

localhost_3000_gitlab-instance-administrators-68dc2b83_gitlab-instance-administration_-packages__2

LATEST

Screenshot_2019-11-15_at_11.27.31

Successful delete:

Screenshot_2019-11-14_at_14.10.50

Group packages list:

Screenshot_2019-11-14_at_14.12.44__2_

Video

screen-capture__8_

Note

The video still contains the old modal confirmation copy, please see latest screenshot for the new one

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #33905 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports