Skip to content

Refactor code to substitute variables in Prometheus queries

Reuben Pereira requested to merge 35242-allow-template-variables into master

What does this MR do?

Refactor the code for substituting variables in Prometheus queries.

Changes this MR contains:

  1. Create service for substituting variables using the Ruby interpolation format (string_%{variable}_string)
    app/services/template_engines/ruby_service.rb.

  2. Create service for substituting variables in the params of the Prometheus Proxy API. This is in preparation for adding support for the Liquid template format in !20793 (merged).
    app/services/prometheus/proxy_variable_substitution_service.rb

Issue: #35242 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports