Skip redis call when IP is whitelisted
What does this MR do?
This addresses gitlab-com/www-gitlab-com#5708 (comment 239133812).
I tested this locally by loading the root page.
Before this change:
❯ gdk redis-cli monitor | grep 'rack::attack'
(in /Users/engwan/Projects/gdk)
1572683191.154006 [0 unix:/Users/engwan/Projects/gdk/redis/redis.socket] "get" "cache:gitlab:rack::attack:allow2ban:ban:127.0.0.1"
1572683193.315181 [0 unix:/Users/engwan/Projects/gdk/redis/redis.socket] "get" "cache:gitlab:rack::attack:allow2ban:ban:127.0.0.1"
1572683194.010053 [0 unix:/Users/engwan/Projects/gdk/redis/redis.socket] "get" "cache:gitlab:rack::attack:allow2ban:ban:127.0.0.1"
After this change:
❯ gdk redis-cli monitor | grep 'rack::attack'
(in /Users/engwan/Projects/gdk)
No calls
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu