Skip to content

Move limits from Plan to new PlanLimits model

Fabio Pitino requested to merge move-limits-out-of-plans into master

What does this MR do?

This MR is targeting add-defaul-plan because it needs changes defined in !19033 (merged)

In this MR we are moving columns related to CI limits from Plan into a PlanLimits model. This refactoring allows us in the future to define namespace-level limits with the same table schema of PlanLimits and have:

class Namespace
  def actual_limit
    limits || actual_plan.limits
  end
end

Also, this means we can add more limits to this table without polluting the Plan's responsibilities.

Related issue: #32823 (closed)

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino

Merge request reports