Skip to content

WIP: Design Repository View (Geo)

Zack Cuddy requested to merge design-repo-view into 34333-expose-an-api-for-design-repositories-for-geo-admin-area

<-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX->

This MR has been closed in favor of splitting it up into 3 separate MRs

Base: !19588 (closed)

Filtering: !19589 (merged)

Actions: !19590 (merged)

<-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX->

Why WIP

This is awaiting some API work, but in the meantime I wanted to open this and point it towards a frontend maintainer to take a look at the frontend parts I have added so far. This is my first frontend feature and want to ensure I interpreted our style guides appropriately.

Also you will notice I used a component from the Bootstrap library instead of Gitlab UI. <b-card> in particular. We don't currently have a <gl-card> component in Gitlab UI. I saw there was some effort towards it that wasn't finished yet gitlab-ui#400 (closed). I wasn't sure what best practice for this situation would be so please let me know!

What does this MR do?

Closes #34336 (closed)

This MR exposes a new view in the Geo Admin Panel focused on Design Repositories. It will mimic what the Projects view in Geo Admin does/looks like, but with the data being specific to Design Repos.

This is WIP because the API this frontend plans to interact with isn't completed yet. Work for that can be tracked via #34333 (closed)

Todo

  • Hook Up API
  • Remove mocked out parts with actual functionality
  • Swap out client-side filtering for server-side
  • Server side pagination
  • TESTSSS

Screenshots

Geo_Designs

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports