Skip to content

Increase review app unicorn gitlab workhorse cpu request

What does this MR do?

This MR increases requested cpu for review-app unicorn pod, gitlab-workhorse container, so that total requested cpu for unicorn pod remains at 700m.

!18673 (merged) increased unicorn/gitlab-workhorse request.cpu by 75 (100m to 175m), but !18712 (merged) reduced unicorn/unicorn request.cpu by 200 (600m to 400m)

Net change on the unicorn pod is less requested cpu (700m to 575m)

This means that kubernetes uses the total required cpu by the pod (575m after both MRs) as reference to schedule pods onto available nodes. Having less total required cpu would cause kubernetes to schedule more pods onto a single node, causing more likelihood for the node CPU to max out.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Albert Salim

Merge request reports