WIP: Fix breaking modal changes
What does this MR do?
Fixes broken modal changes to be introduced by gitlab-ui!767 (merged)
Modal API will be changed to strictly follow the design system.
closes #198310 (closed)
Visually confirmed modals working after refactor
-
app/assets/javascripts/monitoring/components/dashboard.vue
-
app/assets/javascripts/pages/admin/users/components/delete_user_modal.vue
-
app/assets/javascripts/registry/components/collapsible_container.vue
-
app/assets/javascripts/registry/components/table_registry.vue
-
ee/app/assets/javascripts/packages/components/app.vue
-
ee/app/assets/javascripts/packages/list/components/packages_list.vue
-
ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_auth.vue
-
ee/app/assets/javascripts/vue_merge_request_widget/components/visual_review_app_link.vue
-
ee/app/assets/javascripts/alerts_service_settings/components/alerts_service_form.vue
-
app/assets/javascripts/pages/projects/wikis/components/delete_wiki_modal.vue
-
app/assets/javascripts/set_status_modal/set_status_modal_wrapper.vue
-
app/assets/javascripts/clusters/components/uninstall_application_confirmation_modal.vue
-
app/assets/javascripts/environments/components/confirm_rollback_modal.vue
-
app/assets/javascripts/pages/admin/users/components/user_operation_confirmation_modal.vue
-
ee/app/assets/javascripts/approvals/components/modal_rule_create.vue
-
ee/app/assets/javascripts/approvals/components/modal_rule_remove.vue
-
ee/app/assets/javascripts/batch_comments/components/review_bar.vue
-
ee/app/assets/javascripts/custom_metrics/components/delete_custom_metric_modal.vue
-
ee/app/assets/javascripts/dependencies/components/dependency_license_links.vue
-
ee/app/assets/javascripts/design_management/components/delete_button.vue
-
ee/app/assets/javascripts/feature_flags/components/feature_flags_table.vue
-
ee/app/assets/javascripts/environments_dashboard/components/dashboard/dashboard.vue
-
ee/app/assets/javascripts/monitoring/components/alert_widget_form.vue
-
ee/app/assets/javascripts/operations/components/dashboard/dashboard.vue
-
ee/app/assets/javascripts/prometheus_alerts/components/reset_key.vue
-
ee/app/assets/javascripts/related_items_tree/components/tree_item_remove_modal.vue
Screenshots
Todo: Add screenshots of the modal changes
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Dimitrie Hoekstra