Skip to content

WIP: Fix breaking modal changes

Payton Burdette requested to merge fix-breaking-modal-changes into master

What does this MR do?

Fixes broken modal changes to be introduced by gitlab-ui!767 (merged)

Modal API will be changed to strictly follow the design system.

closes #198310 (closed)

Visually confirmed modals working after refactor

  1. app/assets/javascripts/monitoring/components/dashboard.vue
  2. app/assets/javascripts/pages/admin/users/components/delete_user_modal.vue
  3. app/assets/javascripts/registry/components/collapsible_container.vue
  4. app/assets/javascripts/registry/components/table_registry.vue
  5. ee/app/assets/javascripts/packages/components/app.vue
  6. ee/app/assets/javascripts/packages/list/components/packages_list.vue
  7. ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_auth.vue
  8. ee/app/assets/javascripts/vue_merge_request_widget/components/visual_review_app_link.vue
  9. ee/app/assets/javascripts/alerts_service_settings/components/alerts_service_form.vue
  10. app/assets/javascripts/pages/projects/wikis/components/delete_wiki_modal.vue
  11. app/assets/javascripts/set_status_modal/set_status_modal_wrapper.vue
  12. app/assets/javascripts/clusters/components/uninstall_application_confirmation_modal.vue
  13. app/assets/javascripts/environments/components/confirm_rollback_modal.vue
  14. app/assets/javascripts/pages/admin/users/components/user_operation_confirmation_modal.vue
  15. ee/app/assets/javascripts/approvals/components/modal_rule_create.vue
  16. ee/app/assets/javascripts/approvals/components/modal_rule_remove.vue
  17. ee/app/assets/javascripts/batch_comments/components/review_bar.vue
  18. ee/app/assets/javascripts/custom_metrics/components/delete_custom_metric_modal.vue
  19. ee/app/assets/javascripts/dependencies/components/dependency_license_links.vue
  20. ee/app/assets/javascripts/design_management/components/delete_button.vue
  21. ee/app/assets/javascripts/feature_flags/components/feature_flags_table.vue
  22. ee/app/assets/javascripts/environments_dashboard/components/dashboard/dashboard.vue
  23. ee/app/assets/javascripts/monitoring/components/alert_widget_form.vue
  24. ee/app/assets/javascripts/operations/components/dashboard/dashboard.vue
  25. ee/app/assets/javascripts/prometheus_alerts/components/reset_key.vue
  26. ee/app/assets/javascripts/related_items_tree/components/tree_item_remove_modal.vue

Screenshots

Todo: Add screenshots of the modal changes

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dimitrie Hoekstra

Merge request reports