Skip to content

WIP: Fix emoji menu behavior

David Palubin requested to merge dpalubin/gitlab:issue-20166 into master

What does this MR do?

This MR fixes the behavior of the emoji menu when the menu toggle button is pressed to close the menu. Previously, pressing this button to close the menu would cause the is-visible and is-rendered classes of the menu to become out of sync, resulting in unexpected behavior on any later clicks. This MR also corrects unexpected behavior that occurs when clicking a different emoji menu button while there is already an emoji menu open.

Closes #20166 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports